-
Notifications
You must be signed in to change notification settings - Fork 0
chore: 10-iteration quality audit and output stabilization #17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # Command Output Contract | ||
|
|
||
| All command workflows should return results using this structure. | ||
|
|
||
| ## Required sections | ||
|
|
||
| 1. Result | ||
| - One short statement of outcome (done/blocked/partial). | ||
| 2. Changes | ||
| - Files touched and what changed. | ||
| 3. Validation | ||
| - Commands/checks executed and pass/fail status. | ||
| 4. Risks | ||
| - Remaining risks, assumptions, or edge cases. | ||
| 5. Next steps | ||
| - Optional, only when actionable follow-up exists. | ||
|
|
||
| ## Command-specific requirements | ||
|
|
||
| - Review/security commands: | ||
| - Findings first, ordered by severity. | ||
| - Include exact file references. | ||
| - Migration/upgrade commands: | ||
| - Before/after versions. | ||
| - Rollback notes. | ||
| - Build/debug commands: | ||
| - Reproduction command. | ||
| - Root cause and fix verification. | ||
|
|
||
| ## Quality bar | ||
|
|
||
| - Avoid vague summaries without evidence. | ||
| - Prefer concrete file paths and command outputs. | ||
| - Keep conclusions tied to actual checks, not assumptions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Plugin Quality Iterations (2026-02-21) | ||
|
|
||
| Automated quality audit over 10 command iterations. | ||
|
|
||
| | Iteration | Command | Frontmatter | Skill/Workflow Ref | Output Contract | Steps >= 4 | Status | | ||
| |---:|---|---|---|---|---|---| | ||
| | 1 | `implement-flutter-feature` | pass | pass | pass | pass | **PASS** | | ||
| | 2 | `implement-figma-screen` | pass | pass | pass | pass | **PASS** | | ||
| | 3 | `generate-flutter-tests` | pass | pass | pass | pass | **PASS** | | ||
| | 4 | `review-flutter-code` | pass | pass | pass | pass | **PASS** | | ||
| | 5 | `security-review` | pass | pass | pass | pass | **PASS** | | ||
| | 6 | `update-flutter-dependencies` | pass | pass | pass | pass | **PASS** | | ||
| | 7 | `resolve-flutter-build-error` | pass | pass | pass | pass | **PASS** | | ||
| | 8 | `prepare-mobile-release` | pass | pass | pass | pass | **PASS** | | ||
| | 9 | `sync-official-flutter-ai-rules` | pass | pass | pass | pass | **PASS** | | ||
| | 10 | `integrate-firebase` | pass | pass | pass | pass | **PASS** | | ||
|
|
||
| ## Findings | ||
|
|
||
| - Stabilized command output with a shared contract: `docs/command-output-contract.md`. | ||
| - Canonical command set now references the output contract for deterministic response shape. | ||
| - This report is generated by `scripts/quality_audit_commands.sh`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,87 @@ | ||
| #!/usr/bin/env bash | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| repo_root="$(cd "$(dirname "${BASH_SOURCE[0]}")/.." && pwd)" | ||
| commands=( | ||
| "implement-flutter-feature.md" | ||
| "implement-figma-screen.md" | ||
| "generate-flutter-tests.md" | ||
| "review-flutter-code.md" | ||
| "security-review.md" | ||
| "update-flutter-dependencies.md" | ||
| "resolve-flutter-build-error.md" | ||
| "prepare-mobile-release.md" | ||
| "sync-official-flutter-ai-rules.md" | ||
| "integrate-firebase.md" | ||
| ) | ||
|
|
||
| report_file="${repo_root}/docs/quality-iterations-2026-02-21.md" | ||
|
|
||
| { | ||
| echo "# Plugin Quality Iterations (2026-02-21)" | ||
| echo | ||
| echo "Automated quality audit over 10 command iterations." | ||
| echo | ||
| echo "| Iteration | Command | Frontmatter | Skill/Workflow Ref | Output Contract | Steps >= 4 | Status |" | ||
| echo "|---:|---|---|---|---|---|---|" | ||
| } > "${report_file}" | ||
|
|
||
| idx=1 | ||
| all_pass=true | ||
|
|
||
| for cmd in "${commands[@]}"; do | ||
| path="${repo_root}/commands/${cmd}" | ||
| content="$(cat "${path}")" | ||
|
|
||
| has_frontmatter="fail" | ||
| has_skill_or_workflow="fail" | ||
| has_output_contract="fail" | ||
| has_min_steps="fail" | ||
| status="FAIL" | ||
|
|
||
| if grep -Eq '^---' "${path}" && grep -Eq '^name:' "${path}" && grep -Eq '^description:' "${path}"; then | ||
| has_frontmatter="pass" | ||
| fi | ||
|
|
||
| if grep -Eq '(\.\./skills/|templates/|docs/)' "${path}"; then | ||
| has_skill_or_workflow="pass" | ||
| fi | ||
|
|
||
| if grep -Eq 'command-output-contract' "${path}"; then | ||
| has_output_contract="pass" | ||
| fi | ||
|
|
||
| step_count="$(grep -Ec '^[0-9]+\.' "${path}" || true)" | ||
| if [ "${step_count}" -ge 4 ]; then | ||
| has_min_steps="pass" | ||
| fi | ||
|
|
||
| if [ "${has_frontmatter}" = "pass" ] && \ | ||
| [ "${has_skill_or_workflow}" = "pass" ] && \ | ||
| [ "${has_output_contract}" = "pass" ] && \ | ||
| [ "${has_min_steps}" = "pass" ]; then | ||
| status="PASS" | ||
| else | ||
| all_pass=false | ||
| fi | ||
|
|
||
| echo "| ${idx} | \`${cmd%.md}\` | ${has_frontmatter} | ${has_skill_or_workflow} | ${has_output_contract} | ${has_min_steps} | **${status}** |" >> "${report_file}" | ||
| idx=$((idx + 1)) | ||
| done | ||
|
|
||
| { | ||
| echo | ||
| echo "## Findings" | ||
| echo | ||
| echo "- Stabilized command output with a shared contract: \`docs/command-output-contract.md\`." | ||
| echo "- Canonical command set now references the output contract for deterministic response shape." | ||
| echo "- This report is generated by \`scripts/quality_audit_commands.sh\`." | ||
| } >> "${report_file}" | ||
|
|
||
| if [ "${all_pass}" = false ]; then | ||
| echo "Quality audit failed. See ${report_file}" >&2 | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "Quality audit passed. Report: ${report_file}" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
has_skill_or_workflowaudit currently matches anydocs/reference, and every command now includes../docs/command-output-contract.md, so this column will reportpasseven when a command has no skill/workflow linkage. That makes the generated quality report systematically overstate compliance and can hide regressions in command wiring.Useful? React with 👍 / 👎.