Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XDF-05 fix: Future Blocks Are Always Verified Instead Of Queued #497

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

wgr523
Copy link
Collaborator

@wgr523 wgr523 commented Mar 19, 2024

Proposed changes

fix: Future Blocks Are Always Verified Instead Of Queued.

Types of changes

What types of changes does your code introduce to XDC network?
Put an in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Regular KTLO or any of the maintaince work. e.g code style
  • CICD Improvement

Impacted Components

Which part of the codebase this PR will touch base on,

Put an in the boxes that apply

  • Consensus
  • Account
  • Network
  • Geth
  • Smart Contract
  • External components
  • Not sure (Please specify below)

Checklist

Put an in the boxes once you have confirmed below actions (or provide reasons on not doing so) that

  • This PR has sufficient test coverage (unit/integration test) OR I have provided reason in the PR description for not having test coverage
  • Provide an end-to-end test plan in the PR description on how to manually test it on the devnet/testnet.
  • Tested the backwards compatibility.
  • Tested with XDC nodes running this version co-exist with those running the previous version.
  • Relevant documentation has been updated as part of this PR
  • N/A

Copy link
Collaborator

@gzliudan gzliudan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wjrjerome
Copy link
Collaborator

can this be covered by tests?

@wgr523
Copy link
Collaborator Author

wgr523 commented Mar 31, 2024

can this be covered by tests?

As for unit tests, in blockchain_test.go there is lots of tests using InsertChain. So I think coverage it enough.

@wgr523 wgr523 merged commit b535866 into dev-upgrade Apr 1, 2024
34 checks passed
@wgr523 wgr523 deleted the xdf-05 branch April 1, 2024 12:54
wanwiset25 added a commit that referenced this pull request May 10, 2024
wjrjerome pushed a commit that referenced this pull request May 13, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jul 18, 2024
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Jul 26, 2024
wanwiset25 pushed a commit that referenced this pull request Jul 30, 2024
wanwiset25 pushed a commit that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants