Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EN minor grammar fixes, corrected typo in README. #572

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

AwesomeTornado
Copy link
Contributor

There were a few strings with confusing grammar consisting of a question being used as a statement.
I think it's called a subject-auxiliary verb inversion? I'm not a linguistics major though, so I'm not sure.

Example below:
Old version:

  • this controls when is [something] changed
    New version:
  • this controls when [something] is changed

Additionally, I fixed a minor typo in the readme, and a few instances of confusing wording. These are minor changes but should make things easier to read and understand.

@ProbablePrime
Copy link
Member

Native English Speaker(British), yeah these changes are better.

Now there's nothing wrong with this, it is just an observation and not a complaint. I actually find it really interesting. These strings appear to originally be written by Froox. This makes sense, as some of the grammar choices here are common for non-native English speakers. As I said, nothing wrong with this, I just find it interesting!

@AwesomeTornado
Copy link
Contributor Author

Some of the grammar choices here are common for non-native English speakers. As I said, nothing wrong with this, I just find it interesting!

That is interesting, I had assumed that they had been written by a non-native English speaker, and looking at the Czech language (I think that's Froox's native language), it makes sense actually. Czech has a different "default" sentence structure.
Wikipedia: Subject word order in Czech
Wikipedia: Subject word order in various languages

Also, I totally agree that there is nothing inherently "wrong" about mistakes when using different languages, and I highly recommend this fascinating article talking about them.

@Frooxius
Copy link
Member

Frooxius commented Dec 2, 2024

This looks good, thank you for improving the language! Merging in!

@Frooxius Frooxius merged commit 33f5797 into Yellow-Dog-Man:main Dec 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants