Use the Person piece only for publishers.

[pls78]

Context

• The Person schema piece is wrongly generated on authors archive pages ( so when indexable type = 'user') and the site was previously setup to represent a Person different than the author. We want to avoid this.

Summary

This PR can be summarized in the following changelog entry:

• Fixes a bug where an additional Organization, Person schema piece would be wrongly generated for author pages when a website representing an organization was set to represent a person different than the author.

Relevant technical choices:

• The is_needed method of the Person schema piece generator has been updated to not take into account the case in which indexable_type = 'user'. This is because this piece, being of type Organization, Person is meant to represent the website publisher in case the website represents a person. Giving the fact we create a 'user' indexable only for authors, the case is covered by the Author schema piece generator.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

Without this PR - reproduce the bug

• Make sure you have at least two authors in your website
• Go to Yoast SEO -> General First-time configuration tab
• Perform the SEO optimization in step 1
• In step 2 Site representation choose the website to represent a person and choose an author
• Specify the website name and select a picture for the author
• Finish the first-time configuration
• Edit the Site representation step and change the website to represent an organization
• Set both the organization name and the organization logo, then save the changes
• Now visit an author archive page for an author different than the one you have previously selected to be represented by the webpage
  • Verify that you still have a schema piece of type Organization, Person representing the previously selected author

With this PR

• Again, visit an author archive page for an author different than the one you have previously selected to be represented by the webpage
  • Verify that the schema piece of type Organization, Person representing the previously selected author is not generated anymore

Relevant test scenarios

• Changes should be tested with the browser console open
• Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
• Changes should be tested on different editors (Block/Classic/Elementor/other)
• Changes should be tested on different browsers
• Changes should be tested on multisite

Test instructions for QA when the code is in the RC

• QA should use the same steps as above.

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

• Please perform a regression test on schema generation

UI changes

• This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

• This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

• I have written documentation for this change.

Quality assurance

• I have tested this code to the best of my abilities.
• During testing, I had activated all plugins that Yoast SEO provides integrations for.
• I have added unit tests to verify the code works as intended.
• If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
• I have written this PR in accordance with my team's definition of done.
• I have checked that the base branch is correctly set.

Innovation

• No innovation project is applicable for this PR.
• This PR falls under an innovation project. I have attached the innovation label.
• I have added my hours to the WBSO document.

Fixes #20601

[thijsoo]

Awesome works great! CR + ACC 👍