docs: transfer sdk principles and best practices #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VeskeR
requested changes
Jun 24, 2024
There was a problem hiding this comment.
Couple of comments and questsions:
How do we want to handle unresolved inline comments fron the original doc? There are quite a lot of them actually, 33 comment threads total. Also 2 page comments with suggestions for overall structure.
Should also update https://github.com/ably/engineering/blob/main/best-practices/README.md and add a link to this new sdk-principles page.
Need to fix linter erros https://github.com/ably/engineering/actions/runs/9596867014/job/26464675936
ttypic
force-pushed
the
tranfer-sdk-principles
branch
from
4fafc79 to
d4d2e08
Compare
ttypic
force-pushed
the
tranfer-sdk-principles
branch
from
d4d2e08 to
99b17a9
Compare
Transferred 'Client Software (SDK) Principles and Best Practices' from Confluence to GitHub to increase visibility for changes and make it easier to maintain. All changes from now on will be done using PRs to this repo.
ttypic
force-pushed
the
tranfer-sdk-principles
branch
from
99b17a9 to
0a19569
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transferred 'Client Software (SDK) Principles and Best Practices' from Confluence to GitHub to increase visibility for changes and make it easier to maintain. All changes from now on will be done using PRs to this repo.