fix: support shakapacker v7
#441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
upgrade-shakapacker
branch
2 times, most recently
from
31f437f
to
7badb96
Compare
G-Rath
force-pushed
the
upgrade-shakapacker
branch
from
7badb96
to
f65538d
Compare
|
We should try to land this asap because |
|
Yup that's the plan - it should actually be good to go now but for some reason |
G-Rath
requested review from
halles,
joshmcarthur,
robotdana,
robramsaynz,
eoinkelly,
lukeify,
JacobBriggsAckama,
brooke-m,
hopkincame and
mischa-s
eoinkelly
approved these changes
Jul 15, 2023
lukeify
reviewed
Jul 16, 2023
lukeify
approved these changes
Jul 16, 2023
Co-authored-by: Luke <lukedavia@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/shakacode/shakapacker/blob/master/docs/v7_upgrade.md - I havn't yet confirmed if we need to make any changes for the "Stop stripping top-level dirs for static assets" section.