fix: use latest prettier and lock @typescipt-eslint to v5
#443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
requested review from
halles,
joshmcarthur,
robotdana,
robramsaynz,
eoinkelly,
lukeify,
JacobBriggsAckama,
brooke-m,
hopkincame and
mischa-s
joshmcarthur
approved these changes
Jul 11, 2023
lukeify
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had assumed that the new major of
eslint-plugin-prettierwould be compatible with both v2 and v3, but I was wrong - of course it got released after I opened #442...Similarly
@typescript-eslintreleased v6 this week - for now I'm just locking us to v5 to move towards a green CI but expect to do the minor work required to support v6 later this month.