Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use latest prettier and lock @typescipt-eslint to v5 #443

Merged
merged 2 commits into from
Jul 11, 2023
Merged

fix: use latest prettier and lock @typescipt-eslint to v5 #443

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75e44a0
fix: use latest `prettier` as its required by `eslint-plugin-prettier`
G-Rath Jul 11, 2023
806771f
fix: use `@typescript-eslint` v5 for now
G-Rath Jul 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion variants/frontend-base-typescript/template.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ def rename_js_file_to_ts(file)
].map { |name| "@types/#{name}" }

yarn_add_dependencies types_packages + %w[@babel/preset-typescript typescript]
yarn_add_dev_dependencies %w[@typescript-eslint/parser @typescript-eslint/eslint-plugin]
yarn_add_dev_dependencies %w[
@typescript-eslint/parser@5
@typescript-eslint/eslint-plugin@5
]

run "yarn install"

Expand Down
2 changes: 1 addition & 1 deletion variants/frontend-base/js-lint/template.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
eslint-plugin-import
eslint-plugin-prettier
eslint-plugin-eslint-comments
prettier@^2.7.0
prettier
prettier-config-ackama
prettier-plugin-packagejson
]
Expand Down
5 changes: 4 additions & 1 deletion variants/frontend-bootstrap-typescript/template.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
source_paths.unshift(File.dirname(__FILE__))

yarn_add_dependencies %w[@types/bootstrap]
yarn_add_dev_dependencies %w[@typescript-eslint/parser @typescript-eslint/eslint-plugin]
yarn_add_dev_dependencies %w[
@typescript-eslint/parser@5
@typescript-eslint/eslint-plugin@5
]

run "yarn install"

Expand Down