Skip to content

Replace latexcodec with pylatexenc #4279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 0 additions & 73 deletions .github/ISSUE_TEMPLATE/01-metadata-correction.yml

This file was deleted.

14 changes: 7 additions & 7 deletions .github/ISSUE_TEMPLATE/99-bulk-metadata-correction.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,19 @@ body:
- type: markdown
attributes:
value: >
This form is activated by following a link from each paper page in the Anthology (e.g., https://preview.aclanthology.org/autopr/K17-1003/). The form will list the title, abstract, and authors in JSON format, which you can manipulate to make corrections, such as adjusting a title, correcting an author name, adding a missing author, or reordering names.

Please note to take care to preserve structure such as the `<fixed-case>` tag that is sometimes present in titles.

**This form is not meant to be used manually.** Instead, it is activated by clicking the yellow "Fix data" button found on each paper page in the Anthology (e.g., https://aclanthology.org/K17-1003/). Clicking this button displays a UI tool for modifying the title, abstract, and author list. Submission of that form will automatically populate the title above and data block below.
- type: markdown
attributes:
value: >
Corrections will be processed in bulk on a weekly basis after verification by Anthology staff.
- type: textarea
id: data
attributes:
label: JSON code block
description: Please make corrections below, taking care to preserve the JSON structure (e.g., no trailing commas at the end of lists). If you add an author, do not worry about the ID unless you know what it is.
label: JSON data block
description: The JSON data below reflects the changes that were submitted via the paper page dialog.
validations:
required: true
- type: markdown
attributes:
value: |
**Note:** If you request an author name correction for yourself, please help ensure your name is correct for future publications by setting it correctly in Softconf/OpenReview.
**Important:** If you request an author name correction for yourself, please help ensure your name is correct for future publications by setting it correctly in Softconf/OpenReview.
5 changes: 1 addition & 4 deletions .github/workflows/annotate-metadata-issue.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ jobs:
const hasRequiredLabels =
labels.includes('correction') &&
labels.includes('metadata');

core.setOutput('has_required_labels', hasRequiredLabels.toString());

- name: Parse JSON from issue body
Expand Down Expand Up @@ -56,9 +55,7 @@ jobs:
script: |
const anthology_id = core.getInput('anthology_id');
const comment = `
Found ACL Anthology entry:

📄 Paper: https://aclanthology.org/${anthology_id}
Found ACL Anthology entry: https://aclanthology.org/${anthology_id}

![Thumbnail](https://aclanthology.org/thumb/${anthology_id}.jpg)
`;
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/check-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
labels: ubuntu-latest-m
steps:
- name: install hugo
run: wget https://github.com/gohugoio/hugo/releases/download/v0.118.2/hugo_extended_0.118.2_linux-amd64.deb && sudo dpkg -i hugo_extended*.deb
run: wget https://github.com/gohugoio/hugo/releases/download/v0.140.2/hugo_extended_0.140.2_linux-amd64.deb && sudo dpkg -i hugo_extended*.deb
- name: update
run: sudo apt-get update
- name: install other deps
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/preview.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
labels: ubuntu-latest-m
steps:
- name: install hugo
run: wget https://github.com/gohugoio/hugo/releases/download/v0.118.2/hugo_extended_0.118.2_linux-amd64.deb && sudo dpkg -i hugo_extended*.deb
run: wget https://github.com/gohugoio/hugo/releases/download/v0.140.2/hugo_extended_0.140.2_linux-amd64.deb && sudo dpkg -i hugo_extended*.deb
- name: update
run: sudo apt-get update
- name: install other deps
Expand Down
38 changes: 38 additions & 0 deletions .github/workflows/reset-metadata-approval.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
name: Reset Approval on Edit

on:
issues:
types:
- edited

jobs:
reset-approval:
if: contains(join(github.event.issue.labels.*.name, ','), 'correction') || contains(join(github.event.issue.labels.*.name, ','), 'metadata')
runs-on: ubuntu-latest
steps:
- name: Leave a comment and reset approval status
uses: actions/github-script@v6
with:
script: |
const { issue, repository } = context.payload;
const owner = repository.owner.login;
const repo = repository.name;
const approvedLabel = "approved";

// Check if the issue has the "approved" label and remove it
if (issue.labels.some(label => label.name === approvedLabel)) {
await github.rest.issues.removeLabel({
owner,
repo,
issue_number: issue.number,
name: approvedLabel
});

// Add a comment to notify about the edit
await github.rest.issues.createComment({
owner,
repo,
issue_number: issue.number,
body: "Approval status has been reset after the issue was edited."
});
}
144 changes: 0 additions & 144 deletions .github/workflows/validate-metadata-issue.yml

This file was deleted.

2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ repos:
hooks:
- id: insert-license
files: ^python/.*\.py$
args: ['--license-filepath', 'python/LICENSE.header', '--use-current-year']
args: ['--license-filepath', 'python/LICENSE.header', '--allow-past-years']

- repo: https://github.com/psf/black-pre-commit-mirror
rev: 24.3.0
Expand Down
Loading
Loading