Replace latexcodec with pylatexenc #4279
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge v0.5.0 of acl-anthology-py
This PR implements a semi-automated bulk processing workflow for metadata corrections. We hope that it will vastly simplify the metadata correction experience for both users and Anthology staff. It includes the following pieces: * A link is added to each paper page which, when clicked, displays a modal dialog allowing for editing of the paper's title, author list, and abstract * Submitting the dialog takes the user to a Github issue template populated with the changed information in a JSON data block * A new script, process_bulk_metadata.py, processes these work items, makes the corrections, bundles them into a branch, and creates a unified PR * A new Github workflow replaces the old manual one * Documentation regarding workflow corrections is updated --------- Co-authored-by: Matt Post <mattpost@microsoft.com> Co-authored-by: Matt Post <post@cs.jhu.edu>
* Add blog post * Fix approval-resetting workflow * Adjust modal dialog to present checkmark noting that corrections should match the PDF
* Update corrections.md * Update 2024-12-27-new-metadata-workflow.md * Update process_bulk_metadata.py * Update corrections.md * Update 99-bulk-metadata-correction.yml
* Rewrite create_hugo_yaml.py to use new library * Switch create_hugo_pages.py to use rich * Add deprecation warning to old library * Port create_bibtex.py to use new library * Update READMEs * Remove pytest from Makefile (specifically tests the old library)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## python-dev #4279 +/- ##
==============================================
+ Coverage 92.54% 92.56% +0.01%
==============================================
Files 32 32
Lines 2294 2300 +6
==============================================
+ Hits 2123 2129 +6
Misses 171 171
|
* Move build scripts, rename from 'yaml' to 'data' * Remove pytest from Makefile (specifically tests the old library) * Replace PyYAML with msgspec.json * Update READMEs and remove references to libyaml * Add content adapters and remove create_hugo_pages.py * Bump Hugo to v0.140.2 and update READMEs * Don't force the current year in license headers
|
Superseded by #4284 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
latexcodecfor encoding strings in BibTeX entries; the latest version of it recommends to usepylatexencinstead. This PR tests switching to pylatexenc, which slightly changes the logic and encoded strings in some places, but is also faster in my testing.