Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incremented versions for gems to rails 6 ruby 2.7.0 and mongo 7 #153

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

jesusalc
Copy link

M Gemfile
M Gemfile.lock
M activeadmin-mongoid.gemspec

Copy link
Collaborator

@grzegorz-jakubiak grzegorz-jakubiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jesusalc just remove 2.4 from .travis.yml its support ends in march anyways

@deivid-rodriguez
Copy link
Member

I don't understand what this PR is trying to achieve, there's to many unrelated changes in here.

@jesusalc
Copy link
Author

jesusalc commented Feb 4, 2020

I don't understand what this PR is trying to achieve, there's to many unrelated changes in here.

Have tried to use activeadmin-mongoid with Ruby 2.6.5 > MongoId 7 and Rails 6 > ?

@boie0025
Copy link
Member

I don't understand what this PR is trying to achieve, there's to many unrelated changes in here.

It looks like there's some de-linting going on, I'm definitely OK with that.

Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments.


gem.required_ruby_version = '>= 2.4'
gem.required_ruby_version = '>= 2.5'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

gem.add_runtime_dependency 'mongoid', '>= 6.0', '< 8.a'
gem.add_runtime_dependency 'activeadmin', '>= 1.4.3'
gem.add_runtime_dependency 'mongoid', '>= 6.0', '< 8.a'
gem.add_runtime_dependency 'activeadmin', '>= 1.4.3', '<= 2.6.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@@ -2,9 +2,11 @@ source 'https://rubygems.org'

gemspec

gem 'ransack-mongoid', git: 'https://github.com/activerecord-hackery/ransack-mongoid'
# gem 'ransack-mongoid', git: 'https://github.com/activerecord-hackery/ransack-mongoid'
gem 'ransack-mongoid', github: 'jesusalc/ransack-mongoid', branch: 'rails-6-mongoid-7-ruby-2-7-0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we first propose these changes to ransack-mongoid and discuss them there?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jesusalc could you open a PR to ransack-mongoid? That's actually a better idea 😉


gem 'rails', '>= 5.2', '< 6.1'
gem 'webpacker'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed that as well

@jesusalc
Copy link
Author

jesusalc commented Feb 12, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants