-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
incremented versions for gems to rails 6 ruby 2.7.0 and mongo 7 #153
Open
jesusalc
wants to merge
15
commits into
activeadmin:master
Choose a base branch
from
jesusalc:rails-6-mongoid-7-ruby-2-7-0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
8f80bcc
incremented versions for gems to rails 6 ruby 2.7.0 and mongo 7
jesusalc a844845
bumped ruby version to 2.5 for activesupport-6.0.2.1 requires ruby ve…
jesusalc 105be5b
removed random character file =
jesusalc ee40861
bumped version for active admin to 2.6.0
jesusalc bd6af33
corrected offender double quotes to single quotes
jesusalc 5f82ea2
added bump to rails 6 config config.eager_load to environments test d…
jesusalc 2fbba87
added manifest.js file for rails 6 and initial scripts
jesusalc e5acf52
bumped version ransack-mongoid from 0.1.0 to 0.1.1
jesusalc 9ffcce2
bumped version for activeadmin to 2.6.0
jesusalc 7b83d9b
added .freeze to version
jesusalc 61484e9
updated lock file with activeadmin to between 1.4.3 and 2.6.0
jesusalc c731893
updated lock file with activeadmin to between 1.4.3 and 2.6.0
jesusalc 563ece1
removed 2.4 from travis.yml
jesusalc 92fc817
updated activeadmin depency to 3
jesusalc cf7585e
pumped version to 1.0.2
jesusalc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,9 +2,11 @@ source 'https://rubygems.org' | |
|
||
gemspec | ||
|
||
gem 'ransack-mongoid', git: 'https://github.com/activerecord-hackery/ransack-mongoid' | ||
# gem 'ransack-mongoid', git: 'https://github.com/activerecord-hackery/ransack-mongoid' | ||
gem 'ransack-mongoid', github: 'jesusalc/ransack-mongoid', branch: 'rails-6-mongoid-7-ruby-2-7-0' | ||
|
||
gem 'rails', '>= 5.2', '< 6.1' | ||
gem 'webpacker' | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do we need this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I missed that as well |
||
|
||
gem 'devise' | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we first propose these changes to ransack-mongoid and discuss them there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jesusalc could you open a PR to ransack-mongoid? That's actually a better idea 😉