Skip to content

Conversation

@shazron
Copy link
Member

@shazron shazron commented Apr 30, 2024

⚠️ Note: needs https://github.com/adobe/aio-cli-plugin-app-dev installed for debugging - this new plugin should be a core plugin in the aio-cli
🛑 This is a breaking change since it would break aio app run --local functionality. aio app run --local would either need to be removed or a warning shown, or a notice to users that there is a new local debug.

How Has This Been Tested?

  • npm test
  • aio app init MyApp, then running the debugger on an action (works on an app with frontend/extension, --standalone-app has this issue)

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (aeb2f28) to head (6fa5b4e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #801   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           56        56           
  Lines         3173      3173           
  Branches       626       626           
=========================================
  Hits          3173      3173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shazron shazron mentioned this pull request Oct 9, 2024
@purplecabbage purplecabbage merged commit 8bfd693 into master Apr 16, 2025
10 checks passed
@purplecabbage purplecabbage deleted the story/ACNA-2785 branch April 16, 2025 19:28
purplecabbage added a commit that referenced this pull request Nov 10, 2025
… local debugging) (#801)

* fix: ACNA-2785 - run add-vscode-config generator on app init

* updated unit tests

---------

Co-authored-by: Jesse MacFadyen <purplecabbage@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants