-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: major version dependency upgrades, oclif v2 updates #364
Conversation
node-14 has arch issues in the CI, but node-16 doesn't have a problem. Looks like a lockfile version compatibility issue -- it was generated using lockfileVersion@2 (via the npm included in node-16) and that fails in node14. The fix is to use a common npm (we always use the latest) |
…f lockfile version compatibility
Codecov Report
@@ Coverage Diff @@
## master #364 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 4 -1
Lines 247 225 -22
Branches 49 43 -6
=========================================
- Hits 247 225 -22 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
linux tests pass, now we have issues with Windows and |
looks like there are issues with npm@7+ nodejs/node-gyp#508 and node-gyp |
I think we need node-gyp@9 to support Also actions/setup-node#280 |
This issue seems similar nodejs/node-gyp#2683 |
|
One alternative is (see #364 (comment)) we drop support for node-14 testing on Windows and use the |
This reverts commit 1c70bc3.
I believe one of the parcel packages is triggering
|
this might help: parcel-bundler/parcel#8152 |
Hmm 591b1c5 passed, now re-running it, it is failing. seems very flaky |
Looks like, on local testing on Windows, if I delete |
Okay, this all looks reasonable, however it is still very hard to test. |
Description
npm outdated
, only modules that don't have ESM-only updates)How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: