Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: major version dependency upgrades, oclif v2 updates #364

Merged
merged 23 commits into from
Sep 8, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
5ac4d66
fix: update dependencies
shazron Aug 31, 2022
ad371a0
fix: update package-lock.json (fix vulnerable dependencies)
shazron Aug 31, 2022
b9cd79f
fix: bin script for oclif v2
shazron Aug 31, 2022
7a046ae
fix: add space topic separator, remove custom code to handle spaces i…
shazron Aug 31, 2022
8a6f692
fix: add @adobe/aio-cli-plugin-app-templates as a core plugin
shazron Aug 31, 2022
8d8c3b9
fix: remove un-needed tests
shazron Aug 31, 2022
e210843
fix: update README
shazron Aug 31, 2022
9b73c96
fix: in the commit CI, always use the latest version of npm because o…
shazron Aug 31, 2022
69dce0a
fix: update actions/checkout and actions/setup-node versions
shazron Aug 31, 2022
97f7c3b
experiment: set msvs version to 2017 (windows)
shazron Sep 1, 2022
75d15f3
Revert "experiment: set msvs version to 2017 (windows)"
shazron Sep 1, 2022
32ae91d
experiment: use windows-2019
shazron Sep 1, 2022
5b2650a
Revert "experiment: use windows-2019"
shazron Sep 1, 2022
2a39486
fix: update node-gyp if on windows
shazron Sep 1, 2022
663d786
Revert "fix: update node-gyp if on windows"
shazron Sep 1, 2022
1c70bc3
fix: install node-gyp locally (windows)
shazron Sep 1, 2022
5a6e4b8
Revert "fix: install node-gyp locally (windows)"
shazron Sep 7, 2022
feba2b5
add --legacy-peer-deps flag to npm i
shazron Sep 7, 2022
591b1c5
update package-lock.json
shazron Sep 7, 2022
129b3ef
fix: add --legacy-peer-deps flag to `npm ci` as well
shazron Sep 7, 2022
1ceb39d
update package-lock.json (again)
shazron Sep 7, 2022
eb80798
delete package-lock.json before npm i (Windows)
shazron Sep 7, 2022
ba0a74b
fix: update @adobe/aio-cli-plugin-app-templates to ^1.0.0
shazron Sep 7, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/node.js.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,15 +18,18 @@ jobs:
os: [ubuntu-latest, windows-latest]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v2.4.2
with:
fetch-depth: 0
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v3.4.1
with:
node-version: ${{ matrix.node-version }}
- run: npm i --package-lock --package-lock-only
- run: npm ci
# always use the latest npm because of lockfile version compatibility
- run: npm i -g npm@latest
- run: rm package-lock.json
- run: npm i --package-lock --package-lock-only --legacy-peer-deps
- run: npm ci --legacy-peer-deps
- run: npm run build --if-present
- run: npm test
- name: run tests
Expand Down
6,111 changes: 3,181 additions & 2,930 deletions README.md

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions bin/run
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@ OF ANY KIND, either express or implied. See the License for the specific languag
governing permissions and limitations under the License.
*/

require('../src/').run()
.then(require('@oclif/command/flush'))
.catch(require('@oclif/errors/handle'))
const oclif = require('@oclif/core')

oclif.run().then(require('@oclif/core/flush')).catch(require('@oclif/core/handle'))
Loading