fix: update visualizers to use spectrum-design-data URLs#635
Closed
fix: update visualizers to use spectrum-design-data URLs#635
Conversation
…-data - Updated all GitHub repository URLs (189 instances) - Updated all GitHub Pages URLs (2000+ instances) - Updated schema base URI to maintain consistency - Created setup instructions for old repository redirects - Git remote origin updated to new repository URL - Added changeset for the rename Closes #361
- Updated hardcoded repository references from adobe/spectrum-tokens to adobe/spectrum-design-data - Regenerated test snapshots to reflect new schema URLs - All 260 tests now passing
…actices - Changed all $ref values from absolute URLs to relative paths - Kept $id as absolute URIs (required for proper schema identification) - Kept $schema as absolute URIs (required for meta-schema reference) - Updated 180 references across 23 schema files - Follows JSON Schema spec: https://json-schema.org/understanding-json-schema/structuring#base-uri This improves maintainability by using base URI resolution, making schemas more portable and following JSON Schema community best practices.
- Wrap long lines in changeset to meet 100 char limit - Remove OLD_REPO_SETUP.md (content moved to GitHub discussion)
Schema URI changes are breaking for external tools.
…-data The site was still configured to load assets from /spectrum-tokens/ path, causing fonts and other assets to fail loading.
Add smart collapsing behavior to diff report templates: - Details sections with ≤20 items remain open by default - Details sections with >20 items are collapsed by default - Applies to both token and component schema diff reports This improves readability of large diffs like repository-wide changes where hundreds of items would otherwise be expanded by default.
- Add changeset for auto-collapse diff sections feature - Shorten repo-rename changeset to pass linter (under 20 lines)
Add size checks to prevent workflow hangs when diff output exceeds GitHub Actions limits: - Check file size before base64 encoding (750KB limit) - Post helpful message for oversized diffs - Provide local command to run diff manually This fixes the hanging issue on PRs with massive changes like repository-wide renames where every token/component is affected.
- Update visualizer to fetch from spectrum-design-data/s1-legacy - Update s2-visualizer to fetch from spectrum-design-data/beta - Old spectrum-tokens URLs were returning 404
🦋 Changeset detectedLatest commit: 53f558a The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🧩 Component Schema Changes ReportComponent Schemas Changed (0 added, 0 deleted, 85 updated)Original Branch: New Branch: 🚨 Breaking Changes DetectedThis PR introduces 80 breaking change(s) to component schemas. Please review carefully and ensure proper versioning. 💥 Breaking Updates
|
Member
Author
Run report for 53f558a9Total time: 1m | Comparison time: 1m 53s | Estimated savings: 52.9s (46.7% faster)
Expanded report
Touched files |
Contributor
🎨 Token Changes ReportTokens Changed (2338)Original Branch: Updated (2338)Updated Properties (2338)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the visualizers to fetch token data from the renamed repository.
Changes
spectrum-design-data/s1-legacyinstead ofspectrum-tokens/s1-legacyspectrum-design-data/betainstead ofspectrum-tokens/betaIssue
The old
spectrum-tokensURLs were returning 404 errors after the repository rename, preventing the visualizers from loading token data.Testing