fix(dialog-wrapper): update heading to fully span grid area #4810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used header and typeIcon
rubencarvalho
changed the title
Pull Request Test Coverage Report for Build 11363148106Details
💛 - Coveralls |
Tachometer resultsChromecontextual-help permalinkbasic-test
dialog permalinkbasic-test
Firefoxcontextual-help permalinkbasic-test
dialog permalinkbasic-test
|
rubencarvalho
changed the title
rubencarvalho
changed the title
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
rubencarvalho
changed the title
blunteshwar
reviewed
Oct 14, 2024
The failure is about the new screenshot, see example: https://418fbb9265881e994fcd003ef6b56b6f--spectrum-web-components.netlify.app/review/ I will update the golden image cache. |
blunteshwar
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
headerandtypeIcongrid areas were still defined, seemingly without reason, which caused the issue with title wrapping. We’ve added a temporary override to remove these areas from the grid until CSS fixes this on its side.We’re also addressing the
errorattribute, which should have already been in deprecated status (when we remove it, thetypeIcongrid area becomes unnecessary). The alternative is to move towards usingAlert Dialogwithvariant="error"for error cases.Related issue(s)
Motivation and context
This was causing a long dialog title being wrongly formatted, as the original issue above describes.
How has this been tested?
I've added a new story to cover this case.
Screenshots
Before:
After:
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.