Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dialog-wrapper): update heading to fully span grid area #4810

Merged
merged 9 commits into from
Oct 17, 2024
Merged

fix(dialog-wrapper): update heading to fully span grid area #4810

merged 9 commits into from
Oct 17, 2024

Commits on Oct 10, 2024

  1. fix(dialog): update grid-template-areas to use heading instead of uns… 

    …used header and typeIcon
    @rubencarvalho
    rubencarvalho committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    8b3e4e7 View commit details
    Browse the repository at this point in the history

  2. chore: add storybook story to catch regressions

    @rubencarvalho
    rubencarvalho committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    80e705c View commit details
    Browse the repository at this point in the history

  3. chore: add dev warnings and tests

    @rubencarvalho
    rubencarvalho committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5fc41c5 View commit details
    Browse the repository at this point in the history

  4. chore: actually fix the original problem

    @rubencarvalho
    rubencarvalho committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    3c657bf View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. chore: oops did not fix the thing I wanted to fix

    @rubencarvalho
    rubencarvalho committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    27d8cd4 View commit details
    Browse the repository at this point in the history

  2. chore: more selectors

    @rubencarvalho
    rubencarvalho committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    73ab94f View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Merge branch 'main' into ruben/dialog-grid-fix

    @rubencarvalho
    rubencarvalho authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    ef7c7c0 View commit details
    Browse the repository at this point in the history

  2. chore: update golden images hash

    @rubencarvalho
    rubencarvalho committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    9b4edf2 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Merge branch 'main' into ruben/dialog-grid-fix

    @rubencarvalho
    rubencarvalho authored Oct 16, 2024
    Configuration menu
    Copy the full SHA
    d995253 View commit details
    Browse the repository at this point in the history