Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename system 'classic' to 'spectrum' #4830

Merged
merged 1 commit into from
Oct 17, 2024
Merged

chore: rename system 'classic' to 'spectrum' #4830

merged 1 commit into from
Oct 17, 2024

Conversation

rubencarvalho
Copy link
Collaborator

@rubencarvalho rubencarvalho commented Oct 16, 2024 •
edited
Loading

Description

There were some forgotten instances of system='classic'. This PR updates them!

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@rubencarvalho rubencarvalho changed the base branch from main to ruben/remove-deprecations October 16, 2024 20:48
@rubencarvalho rubencarvalho changed the base branch from ruben/remove-deprecations to ruben/remove-theme October 16, 2024 20:48
@rubencarvalho rubencarvalho marked this pull request as ready for review October 16, 2024 20:48
@rubencarvalho rubencarvalho requested a review from a team as a code owner October 16, 2024 20:48
@rubencarvalho rubencarvalho mentioned this pull request Oct 16, 2024
Merged
11 tasks
@github-actions GitHub Actions
Copy link

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

@github-actions GitHub Actions
Copy link

Lighthouse scores

Category Latest (report) Main (report) Branch (report)
Performance 0.99 0.99 0.99
Accessibility 1 1 1
Best Practices 1 1 1
SEO 1 0.92 0.92
PWA 1 1 1
What is this?

Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on main ("Main"). Higher scores are better, but note that the SEO scores on Netlify URLs are artifically constrained to 0.92.

Transfer Size

Category Latest Main Branch
Total 227.869 kB 217.147 kB 🏆 217.253 kB
Scripts 56.996 kB 52.405 kB 🏆 52.605 kB
Stylesheet 34.844 kB 30.191 kB 🏆 30.219 kB
Document 6.213 kB 5.49 kB 5.466 kB 🏆
Font 126.826 kB 126.615 kB 126.614 kB 🏆

Request Count

Category Latest Main Branch
Total 52 52 52
Scripts 41 41 41
Stylesheet 5 5 5
Document 1 1 1
Font 2 2 2

@github-actions GitHub Actions
Copy link

Tachometer results

Chrome

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 503 kB 53.00ms - 54.14ms - faster ✔
2% - 5%
1.10ms - 2.58ms
branch 478 kB 54.94ms - 55.88ms slower ❌
2% - 5%
1.10ms - 2.58ms		 -

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 706 kB 140.49ms - 143.89ms - faster ✔
4% - 8%
6.60ms - 12.14ms
branch 663 kB 149.37ms - 153.75ms slower ❌
5% - 9%
6.60ms - 12.14ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 663 kB 68.80ms - 70.05ms - faster ✔
7% - 9%
4.87ms - 7.07ms
branch 620 kB 74.49ms - 76.30ms slower ❌
7% - 10%
4.87ms - 7.07ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 662 kB 67.31ms - 68.46ms - faster ✔
7% - 9%
4.94ms - 6.89ms
branch 619 kB 73.02ms - 74.58ms slower ❌
7% - 10%
4.94ms - 6.89ms		 -

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 852 kB 1872.80ms - 1876.10ms - unsure 🔍
-0% - +0%
-2.77ms - +1.55ms
branch 806 kB 1873.66ms - 1876.45ms unsure 🔍
-0% - +0%
-1.55ms - +2.77ms		 -

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 850 kB 1877.53ms - 1880.00ms - unsure 🔍
-0% - +0%
-1.60ms - +2.35ms
branch 804 kB 1876.84ms - 1879.93ms unsure 🔍
-0% - +0%
-2.35ms - +1.60ms		 -

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 723 kB 529.94ms - 535.10ms - faster ✔
0% - 2%
2.66ms - 10.54ms
branch 680 kB 536.15ms - 542.10ms slower ❌
0% - 2%
2.66ms - 10.54ms		 -

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 765 kB 38.19ms - 38.88ms - faster ✔
1% - 3%
0.49ms - 1.28ms
branch 719 kB 39.22ms - 39.61ms slower ❌
1% - 3%
0.49ms - 1.28ms		 -

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 765 kB 409.14ms - 414.78ms - faster ✔
2% - 4%
6.86ms - 17.49ms
branch 720 kB 419.63ms - 428.64ms slower ❌
2% - 4%
6.86ms - 17.49ms		 -

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 694 kB 52.82ms - 54.74ms - faster ✔
5% - 10%
2.76ms - 5.77ms
branch 648 kB 56.88ms - 59.21ms slower ❌
5% - 11%
2.76ms - 5.77ms		 -

dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 558 kB 78.45ms - 79.63ms - unsure 🔍
-2% - +0%
-1.25ms - +0.13ms
branch 515 kB 79.26ms - 79.95ms unsure 🔍
-0% - +2%
-0.13ms - +1.25ms		 -

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 496 kB 210.07ms - 212.84ms - faster ✔
2% - 4%
3.22ms - 7.97ms
branch 471 kB 215.12ms - 218.98ms slower ❌
2% - 4%
3.22ms - 7.97ms		 -

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 745 kB 454.08ms - 476.90ms - unsure 🔍
-3% - +3%
-12.35ms - +11.87ms
branch 702 kB 461.67ms - 469.78ms unsure 🔍
-3% - +3%
-11.87ms - +12.35ms		 -

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 827 kB 24.57ms - 25.08ms - faster ✔
4% - 7%
1.11ms - 1.90ms
branch 781 kB 26.03ms - 26.64ms slower ❌
4% - 8%
1.11ms - 1.90ms		 -

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 816 kB 369.02ms - 373.73ms - faster ✔
1% - 3%
5.57ms - 11.51ms
branch 770 kB 378.10ms - 381.73ms slower ❌
1% - 3%
5.57ms - 11.51ms		 -

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 612 kB 43.24ms - 44.46ms - faster ✔
5% - 8%
2.44ms - 3.97ms
branch 566 kB 46.60ms - 47.51ms slower ❌
5% - 9%
2.44ms - 3.97ms		 -

picker-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 430 kB 27.51ms - 28.05ms - faster ✔
4% - 7%
1.12ms - 2.21ms
branch 405 kB 28.97ms - 29.91ms slower ❌
4% - 8%
1.12ms - 2.21ms		 -

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 570 kB 524.12ms - 532.56ms - faster ✔
1% - 3%
3.45ms - 14.77ms
branch 527 kB 533.67ms - 541.22ms slower ❌
1% - 3%
3.45ms - 14.77ms		 -

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 397 kB 11.24ms - 11.38ms - faster ✔
1% - 4%
0.15ms - 0.42ms
branch 374 kB 11.49ms - 11.71ms slower ❌
1% - 4%
0.15ms - 0.42ms		 -

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 496 kB 76.52ms - 77.99ms - faster ✔
3% - 6%
2.76ms - 5.18ms
branch 471 kB 80.27ms - 82.18ms slower ❌
4% - 7%
2.76ms - 5.18ms		 -

split-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 784 kB 1868.30ms - 1873.27ms - unsure 🔍
-0% - +0%
-0.26ms - +6.25ms
branch 739 kB 1865.69ms - 1869.89ms unsure 🔍
-0% - +0%
-6.25ms - +0.26ms		 -

table permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 547 kB 125.26ms - 128.85ms - faster ✔
2% - 5%
2.75ms - 7.08ms
branch 498 kB 130.77ms - 133.17ms slower ❌
2% - 6%
2.75ms - 7.08ms		 -

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 626 kB 33.86ms - 34.41ms - faster ✔
4% - 7%
1.57ms - 2.45ms
branch 579 kB 35.80ms - 36.48ms slower ❌
5% - 7%
1.57ms - 2.45ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 584 kB 23.44ms - 23.94ms - faster ✔
8% - 11%
2.05ms - 2.77ms
branch 541 kB 25.84ms - 26.36ms slower ❌
9% - 12%
2.05ms - 2.77ms		 -

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 709 kB 51.95ms - 52.81ms - faster ✔
5% - 8%
2.86ms - 4.26ms
branch 663 kB 55.39ms - 56.50ms slower ❌
5% - 8%
2.86ms - 4.26ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 684 kB 42.34ms - 43.41ms - faster ✔
7% - 10%
3.25ms - 4.68ms
branch 639 kB 46.36ms - 47.32ms slower ❌
7% - 11%
3.25ms - 4.68ms		 -

tray permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 572 kB 101.58ms - 102.33ms - faster ✔
1% - 3%
0.79ms - 2.79ms
branch 529 kB 102.82ms - 104.68ms slower ❌
1% - 3%
0.79ms - 2.79ms		 -

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 546 kB 60.34ms - 64.66ms - unsure 🔍
-7% - +1%
-4.36ms - +0.90ms
branch 519 kB 62.73ms - 65.73ms unsure 🔍
-2% - +7%
-0.90ms - +4.36ms		 -
Firefox

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 503 kB 112.77ms - 119.75ms - unsure 🔍
-6% - +1%
-7.73ms - +0.93ms
branch 478 kB 117.10ms - 122.22ms unsure 🔍
-1% - +7%
-0.93ms - +7.73ms		 -

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 706 kB 268.86ms - 271.62ms - faster ✔
12% - 13%
36.01ms - 40.75ms
branch 663 kB 306.69ms - 310.55ms slower ❌
13% - 15%
36.01ms - 40.75ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 663 kB 135.61ms - 137.91ms - unsure 🔍
-0% - +2%
-0.19ms - +2.51ms
branch 620 kB 134.89ms - 136.31ms unsure 🔍
-2% - +0%
-2.51ms - +0.19ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 662 kB 128.22ms - 131.10ms - faster ✔
3% - 7%
4.19ms - 9.37ms
branch 619 kB 134.29ms - 138.59ms slower ❌
3% - 7%
4.19ms - 9.37ms		 -

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 852 kB 1885.05ms - 1890.75ms - unsure 🔍
-0% - +0%
-6.41ms - +2.09ms
branch 806 kB 1886.90ms - 1893.22ms unsure 🔍
-0% - +0%
-2.09ms - +6.41ms		 -

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 850 kB 1890.88ms - 1895.64ms - unsure 🔍
-0% - +0%
-6.83ms - +0.83ms
branch 804 kB 1893.27ms - 1899.25ms unsure 🔍
-0% - +0%
-0.83ms - +6.83ms		 -

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 723 kB 793.20ms - 802.72ms - faster ✔
1% - 4%
10.17ms - 31.83ms
branch 680 kB 809.23ms - 828.69ms slower ❌
1% - 4%
10.17ms - 31.83ms		 -

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 765 kB 66.01ms - 72.31ms - slower ❌
6% - 17%
3.84ms - 10.48ms
branch 719 kB 60.93ms - 63.07ms faster ✔
6% - 15%
3.84ms - 10.48ms		 -

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 765 kB 688.61ms - 700.35ms - slower ❌
0% - 3%
1.41ms - 21.39ms
branch 720 kB 675.00ms - 691.16ms faster ✔
0% - 3%
1.41ms - 21.39ms		 -

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 694 kB 110.83ms - 119.17ms - unsure 🔍
-7% - +3%
-7.76ms - +3.28ms
branch 648 kB 113.63ms - 120.85ms unsure 🔍
-3% - +7%
-3.28ms - +7.76ms		 -

dialog permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 558 kB 117.46ms - 123.10ms - unsure 🔍
-3% - +3%
-3.37ms - +3.97ms
branch 515 kB 117.63ms - 122.33ms unsure 🔍
-3% - +3%
-3.97ms - +3.37ms		 -

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 496 kB 416.53ms - 429.15ms - faster ✔
1% - 5%
3.95ms - 23.25ms
branch 471 kB 429.14ms - 443.74ms slower ❌
1% - 6%
3.95ms - 23.25ms		 -

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 823 kB 615.09ms - 630.87ms - slower ❌
2% - 5%
13.98ms - 30.46ms
branch 777 kB 598.40ms - 603.12ms faster ✔
2% - 5%
13.98ms - 30.46ms		 -

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 827 kB 46.39ms - 47.01ms - faster ✔
4% - 6%
1.72ms - 2.80ms
branch 781 kB 48.52ms - 49.40ms slower ❌
4% - 6%
1.72ms - 2.80ms		 -

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 816 kB 633.86ms - 641.50ms - slower ❌
3% - 5%
19.64ms - 29.84ms
branch 770 kB 609.56ms - 616.32ms faster ✔
3% - 5%
19.64ms - 29.84ms		 -

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 612 kB 95.85ms - 103.75ms - slower ❌
3% - 12%
3.22ms - 11.34ms
branch 566 kB 91.55ms - 93.49ms faster ✔
4% - 11%
3.22ms - 11.34ms		 -

picker-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 430 kB 59.10ms - 63.70ms - unsure 🔍
-10% - +1%
-6.52ms - +0.96ms
branch 405 kB 61.23ms - 67.13ms unsure 🔍
-2% - +11%
-0.96ms - +6.52ms		 -

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 570 kB 960.98ms - 976.98ms - faster ✔
4% - 7%
42.69ms - 76.91ms
branch 527 kB 1013.66ms - 1043.90ms slower ❌
4% - 8%
42.69ms - 76.91ms		 -

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 397 kB 27.89ms - 31.27ms - unsure 🔍
-11% - +4%
-3.56ms - +1.24ms
branch 374 kB 29.04ms - 32.44ms unsure 🔍
-4% - +12%
-1.24ms - +3.56ms		 -

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 496 kB 155.68ms - 164.40ms - faster ✔
0% - 8%
0.63ms - 12.81ms
branch 471 kB 162.50ms - 171.02ms slower ❌
0% - 8%
0.63ms - 12.81ms		 -

split-button permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 784 kB 1874.70ms - 1879.18ms - unsure 🔍
-0% - -0%
-7.64ms - -0.72ms
branch 739 kB 1878.48ms - 1883.76ms unsure 🔍
+0% - +0%
+0.72ms - +7.64ms		 -

table permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 547 kB 269.11ms - 277.97ms - unsure 🔍
-3% - +1%
-8.81ms - +3.09ms
branch 498 kB 272.43ms - 280.37ms unsure 🔍
-1% - +3%
-3.09ms - +8.81ms		 -

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 708 kB 73.54ms - 77.86ms - slower ❌
6% - 13%
4.33ms - 9.11ms
branch 663 kB 67.97ms - 69.99ms faster ✔
6% - 12%
4.33ms - 9.11ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 584 kB 44.01ms - 45.27ms - faster ✔
20% - 27%
11.36ms - 16.44ms
branch 541 kB 56.08ms - 61.00ms slower ❌
25% - 37%
11.36ms - 16.44ms		 -

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 709 kB 106.80ms - 113.88ms - faster ✔
2% - 9%
2.02ms - 11.10ms
branch 663 kB 114.05ms - 119.75ms slower ❌
2% - 10%
2.02ms - 11.10ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 684 kB 85.23ms - 88.69ms - faster ✔
4% - 9%
3.54ms - 8.46ms
branch 639 kB 91.21ms - 94.71ms slower ❌
4% - 10%
3.54ms - 8.46ms		 -

tray permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 572 kB 160.38ms - 167.46ms - unsure 🔍
-6% - +0%
-9.99ms - +0.39ms
branch 529 kB 164.92ms - 172.52ms unsure 🔍
-0% - +6%
-0.39ms - +9.99ms		 -

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 546 kB 93.57ms - 99.95ms - unsure 🔍
-8% - +0%
-8.43ms - +0.27ms
branch 519 kB 97.88ms - 103.80ms unsure 🔍
-0% - +9%
-0.27ms - +8.43ms		 -

blunteshwar
blunteshwar approved these changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@blunteshwar blunteshwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ,Approved!

@rubencarvalho rubencarvalho merged commit a671e2c into ruben/remove-theme Oct 17, 2024
43 of 45 checks passed
@rubencarvalho rubencarvalho deleted the ruben/rename-classic-theme branch October 17, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blunteshwar blunteshwar blunteshwar approved these changes

@Rajdeepc Rajdeepc Awaiting requested review from Rajdeepc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubencarvalho @blunteshwar