Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from boost pointer to std pointer #39

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Conversation

Kotochleb
Copy link
Collaborator

In order to keep up with the latest changes in Crocoddyl I am updating this repo to use std::shared_ptr instead of boost::shared_ptr.

Copy link
Contributor

@nim65s nim65s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you fix pre-commit ? I'll handle the nix part.

@Kotochleb
Copy link
Collaborator Author

@nim65s I will do pre-commit in a different PR as it complains about files that are unrelated to those changes

Copy link
Contributor

@jmirabel jmirabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as the compiler is happy, I'm happy for this kind of changes.

@Kotochleb
Copy link
Collaborator Author

pre-commit fixed in #40

@nim65s
Copy link
Contributor

nim65s commented Feb 10, 2025

@Mergifyio rebase

Copy link

mergify bot commented Feb 10, 2025

rebase

⚠️ Cannot use the command rebase

⚠ The product Workflow automation needs to be activated to enable this feature.

@nim65s
Copy link
Contributor

nim65s commented Feb 10, 2025

@Mergifyio rebase

Copy link

mergify bot commented Feb 10, 2025

rebase

✅ Branch has been successfully rebased

@nim65s nim65s force-pushed the bugfix/boost-to-std-pointer branch from 4963e78 to ab2509c Compare February 10, 2025 13:41
@nim65s nim65s merged commit 6f94d57 into main Feb 10, 2025
4 checks passed
@Kotochleb Kotochleb deleted the bugfix/boost-to-std-pointer branch February 10, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants