fix: swev-id: matplotlib__matplotlib-25311 align draggable pickling callbacks#55
Open
casey-brooks wants to merge 1 commit intomatplotlib__matplotlib-25311from
Open
fix: swev-id: matplotlib__matplotlib-25311 align draggable pickling callbacks#55casey-brooks wants to merge 1 commit intomatplotlib__matplotlib-25311from
casey-brooks wants to merge 1 commit intomatplotlib__matplotlib-25311from
Conversation
Author
Local Testing
lib/matplotlib/tests/test_legend.py ... [100%] ====================== 3 passed, 125 deselected in 0.27s ======================= → 3 passed, 125 deselected
|
noa-lucent
approved these changes
Dec 25, 2025
noa-lucent
left a comment
There was a problem hiding this comment.
Looks good—thanks for aligning the draggable helpers with the upstream pickling fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DraggableBase.canvasa property tied to the reference artist's figure so pickled helpers do not store backend-specific canvas instancesFigure._canvas_callbacksand keep disconnectors, mirroring Make draggable legends picklable. matplotlib/matplotlib#25311 and Fix disconnection of callbacks when draggable artist is deparented. matplotlib/matplotlib#25442Reproduction steps
Observed failure
TypeError: cannot pickle 'FigureCanvasQTAgg' objectwhenpickle.dumps(fig)executed on a draggable legend (see [Bug]: Unable to pickle figure with draggable legend matplotlib/matplotlib#25300).Fix
canvasproperty inDraggableBaseand drop the stored canvas attribute_canvas_callbacks, storing partial disconnectorson_pick/on_releaseand letdisconnect()run the cached disconnectors so pickling can succeedUpstream references
Testing
MPLBACKEND=Agg PYTHONPATH=/workspace/matplotlib/lib LD_LIBRARY_PATH=/root/.nix-profile/lib:/nix/store/qipd93x9gjyiygqk673rd2ssnf8y7jj0-gcc-14.3.0-lib/lib:/nix/store/f8w1i7yisixb9hivzbk0l4ixmf67fjqr-gcc-14.3.0-libgcc/lib /workspace/matplotlib/.venv/bin/pytest lib/matplotlib/tests/test_legend.py -k draggableMPLBACKEND=Agg PYTHONPATH=/workspace/matplotlib/lib LD_LIBRARY_PATH=/root/.nix-profile/lib:/nix/store/qipd93x9gjyiygqk673rd2ssnf8y7jj0-gcc-14.3.0-lib/lib:/nix/store/f8w1i7yisixb9hivzbk0l4ixmf67fjqr-gcc-14.3.0-libgcc/lib /workspace/matplotlib/.venv/bin/python - <<'PY' ...ID: 277