Skip to content

fix: swev-id: matplotlib__matplotlib-25311 align draggable pickling callbacks #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
casey-brooks wants to merge 1 commit into
base: matplotlib__matplotlib-25311
Choose a base branch
from
Open

fix: swev-id: matplotlib__matplotlib-25311 align draggable pickling callbacks #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 20 additions & 18 deletions lib/matplotlib/offsetbox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1500,18 +1500,29 @@ def finalize_offset(self):
coordinate and set a relevant attribute.
"""

canvas = property(lambda self: self.ref_artist.figure.canvas)

def __init__(self, ref_artist, use_blit=False):
self.ref_artist = ref_artist
if not ref_artist.pickable():
ref_artist.set_picker(True)
self.got_artist = False
self.canvas = self.ref_artist.figure.canvas
self._use_blit = use_blit and self.canvas.supports_blit
self.cids = [
self.canvas.callbacks._connect_picklable(
'pick_event', self.on_pick),
self.canvas.callbacks._connect_picklable(
'button_release_event', self.on_release),
figure = self.ref_artist.figure
canvas = figure.canvas
self._use_blit = use_blit and canvas.supports_blit
callbacks = figure._canvas_callbacks
self._disconnectors = [
functools.partial(
callbacks.disconnect,
callbacks._connect_picklable('pick_event', self.on_pick)),
functools.partial(
callbacks.disconnect,
callbacks._connect_picklable(
'button_release_event', self.on_release)),
functools.partial(
callbacks.disconnect,
callbacks._connect_picklable(
'motion_notify_event', self.on_motion)),
]

def on_motion(self, evt):
Expand Down Expand Up @@ -1540,15 +1551,12 @@ def on_pick(self, evt):
self.ref_artist.draw(
self.ref_artist.figure._get_renderer())
self.canvas.blit()
self._c1 = self.canvas.callbacks._connect_picklable(
"motion_notify_event", self.on_motion)
self.save_offset()

def on_release(self, event):
if self._check_still_parented() and self.got_artist:
self.finalize_offset()
self.got_artist = False
self.canvas.mpl_disconnect(self._c1)

if self._use_blit:
self.ref_artist.set_animated(False)
Expand All @@ -1562,14 +1570,8 @@ def _check_still_parented(self):

def disconnect(self):
"""Disconnect the callbacks."""
for cid in self.cids:
self.canvas.mpl_disconnect(cid)
try:
c1 = self._c1
except AttributeError:
pass
else:
self.canvas.mpl_disconnect(c1)
for disconnect in self._disconnectors:
disconnect()

def save_offset(self):
pass
Expand Down