Fix Warning coming from ProcessFollowerWidget #512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was missed when we changed the ProcessMonitor to use Process UUID as its traitlet.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #512 +/- ##
=======================================
Coverage 79.31% 79.31%
=======================================
Files 27 27
Lines 3834 3834
=======================================
Hits 3041 3041
Misses 793 793
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here. |
danielhollas
commented
Sep 7, 2023
unkcpz
reviewed
Sep 7, 2023
|
@unkcpz, since you are reviewing it, I will un-assign myself. I trust you guys :) |
danielhollas
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was missed when we changed the ProcessMonitor to use Process UUID as its traitlet. I discovered this when I was trying to get rid of warnings in unit tests in #509
@yakutovicha @unkcpz I am not very familiar with this Widget, could you please test it?