Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Filtering Functionality and new locations to Trekking page #225

Merged
merged 3 commits into from
Oct 28, 2024

Conversation

IkkiOcean
Copy link
Contributor

Description

This PR introduces the ability to filter treks based on difficulty level, district, and altitude in the Trekking component. Additionally, it implements a "not available" message to inform users when no treks match the selected filters. This enhancement significantly improves the user experience by providing clear feedback and functionality.

Changes Made

  • Filter Functionality:

    • Implemented filtering logic that allows users to filter treks based on:
      • Difficulty Level: Options include EASY, EASY TO MODERATE, MODERATE, MODERATE TO DIFFICULT, DEMANDING, and HIGH RISK.
      • District: Dynamically generated list of unique districts from the trek data.
      • Altitude: Options for Low, Moderate, and High based on altitude ranges.
  • "Not Available" Message:

    • Added a div that displays the message "No treks available based on your filters. Please adjust your selections." when no treks match the filters.
    • Ensured the message is styled for visibility and centered within the card container.
  • Added content for the following treks:

    • Chandrashila Trek (Moderate, 4000 m, Rudraprayag)
    • Kedarkantha Trek (Easy to Moderate, 3810 m, Uttarkashi)
    • Nag Tibba Trek (Easy, 3022 m, Tehri Garhwal)
    • Roopkund Trek (Moderate, 5029 m, Chamoli)
    • Kalindi Khal Trek (Difficult, 5950 m, Chamoli)
    • Tarsar Marsar Trek (Moderate, 4000 m, Anantnag)

Screenshot

Screenshot 2024-10-27 at 4 31 57 PM

Video

repo.mp4

Related Issues

Copy link

vercel bot commented Oct 27, 2024

@IkkiOcean is attempting to deploy a commit to the ajaynegi45's projects Team on Vercel.

A member of the Team first needs to authorize it.

@IkkiOcean IkkiOcean changed the title Filter functionality Added Filtering Functionality and new locations to Trekking page Oct 27, 2024
@IkkiOcean
Copy link
Contributor Author

I add all the location I could find, and made the filter option design what it used to look like.

Copy link

vercel bot commented Oct 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
uttarakhand-culture ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 28, 2024 5:21am

Copy link
Owner

@ajaynegi45 ajaynegi45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @IkkiOcean,

Thank you for your prompt work on this issue. I appreciate your dedication to the project.

I have reviewed your work, and I need some changes.

  • There is no district name Kumaon.

    Screenshot 2024-10-27 at 10 58 54 PM
  • Don't Dynamically generated list of district. Just add all present district name. As it was earlier.

  • Don't add too much difficulty level. Only the three are best. Make simple and easy for user.

  • The added trek are the best treks. Add more trek, make it goto guide for trekers

  • Add google maps location link there. So that user can find best routes from there place

  • Add more info about that trek like history or any story etc. Tell something interesting about that trek. Add eye catching info in outer paragraph so that user click it. I think remove the overview part and add all that info in outer para and if there is so long info then add it inside but without overview heading

    Screenshot 2024-10-27 at 11 07 46 PM
  • Make one more section that if there is need of any special permission or registeration for that trek then add that process and all permission required and links etc.

  • You haven't star the repo. Star the repo 🌟 to help us grow

Once again, thank you for your contribution! ❤️

@ajaynegi45 ajaynegi45 added enhancement New feature or request status: ready for dev You can asked for this issue to be assigned (if not already assigned) hacktoberfest hacktoberfest gssoc GirlScript Summer Of Code hacktoberfest-accepted hacktoberfest level3 GirlScript Summer Of Code - 35 points gssoc-ext GirlScript Summer Of Code labels Oct 27, 2024
@IkkiOcean
Copy link
Contributor Author

IkkiOcean commented Oct 27, 2024

@ajaynegi45 hey, I completed some of the changes you asked for.

  • I made the level choice to only three i.e easy, moderate and difficult
  • I listed the district as it was earlier and filter will work using that.

As my this issue was about the filter but I still added some trek sites on your demand. I wanna work on the other features you mentioned but in a different issue as those deviates from the problems mentioned in the issue.

  • regarding location, I have already raised and has been assigned for the feature of adding map to location button, and Im working on that, I will raise the PR soon for it.
  • About adding more details and information about the trekking location, as I have already said earlier its not a good idea adding more data to website without proper implementation of a database, but I can do it in a separate issue if you want but I would recommend setting up a database, which I can also help in.
  • I starred the repo, im sorry for not doing it till now, as It slipped my mind.

My request is that you merge this PR so that I can move forward with development of map because I dont wanna cause merge conflicts.

Copy link
Owner

@ajaynegi45 ajaynegi45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @IkkiOcean,

Thank you for your prompt work on this issue. I appreciate your dedication to the project.

I have reviewed your work, and I'm pleased to inform you that I have merged your pull request. Your changes looks fantastic, and it aligns perfectly with the project's design and usability goals. Great job!

If you have any more contributions or if there's anything else you'd like to work on in the future, please don't hesitate to let us know. Your efforts are valuable to the project's success.

Once again, thank you for your contribution! ❤️

@ajaynegi45
Copy link
Owner

Hi @IkkiOcean,

Thank you for your prompt work on this issue. I appreciate your dedication to the project.

I have reviewed your work, and I need some changes.

  • There is no district name Kumaon.
    Screenshot 2024-10-27 at 10 58 54 PM
  • Don't Dynamically generated list of district. Just add all present district name. As it was earlier.
  • Don't add too much difficulty level. Only the three are best. Make simple and easy for user.
  • The added trek are the best treks. Add more trek, make it goto guide for trekers
  • Add google maps location link there. So that user can find best routes from there place
  • Add more info about that trek like history or any story etc. Tell something interesting about that trek. Add eye catching info in outer paragraph so that user click it. I think remove the overview part and add all that info in outer para and if there is so long info then add it inside but without overview heading
    Screenshot 2024-10-27 at 11 07 46 PM
  • Make one more section that if there is need of any special permission or registeration for that trek then add that process and all permission required and links etc.
  • You haven't star the repo. Star the repo 🌟 to help us grow

Once again, thank you for your contribution! ❤️

Implement these issue in future pr

@ajaynegi45 ajaynegi45 merged commit 7afbe55 into ajaynegi45:main Oct 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request gssoc GirlScript Summer Of Code gssoc-ext GirlScript Summer Of Code hacktoberfest hacktoberfest hacktoberfest-accepted hacktoberfest level3 GirlScript Summer Of Code - 35 points status: ready for dev You can asked for this issue to be assigned (if not already assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add Filtering Option for Trekking Locations
2 participants