-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Filtering Functionality and new locations to Trekking page #225
Conversation
@IkkiOcean is attempting to deploy a commit to the ajaynegi45's projects Team on Vercel. A member of the Team first needs to authorize it. |
I add all the location I could find, and made the filter option design what it used to look like. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @IkkiOcean,
Thank you for your prompt work on this issue. I appreciate your dedication to the project.
I have reviewed your work, and I need some changes.
-
There is no district name Kumaon.
-
Don't Dynamically generated list of district. Just add all present district name. As it was earlier.
-
Don't add too much difficulty level. Only the three are best. Make simple and easy for user.
-
The added trek are the best treks. Add more trek, make it goto guide for trekers
-
Add google maps location link there. So that user can find best routes from there place
-
Add more info about that trek like history or any story etc. Tell something interesting about that trek. Add eye catching info in outer paragraph so that user click it. I think remove the overview part and add all that info in outer para and if there is so long info then add it inside but without overview heading
-
Make one more section that if there is need of any special permission or registeration for that trek then add that process and all permission required and links etc.
-
You haven't star the repo. Star the repo 🌟 to help us grow
Once again, thank you for your contribution! ❤️
@ajaynegi45 hey, I completed some of the changes you asked for.
As my this issue was about the filter but I still added some trek sites on your demand. I wanna work on the other features you mentioned but in a different issue as those deviates from the problems mentioned in the issue.
My request is that you merge this PR so that I can move forward with development of map because I dont wanna cause merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @IkkiOcean,
Thank you for your prompt work on this issue. I appreciate your dedication to the project.
I have reviewed your work, and I'm pleased to inform you that I have merged your pull request. Your changes looks fantastic, and it aligns perfectly with the project's design and usability goals. Great job!
If you have any more contributions or if there's anything else you'd like to work on in the future, please don't hesitate to let us know. Your efforts are valuable to the project's success.
Once again, thank you for your contribution! ❤️
Implement these issue in future pr |
Description
This PR introduces the ability to filter treks based on difficulty level, district, and altitude in the Trekking component. Additionally, it implements a "not available" message to inform users when no treks match the selected filters. This enhancement significantly improves the user experience by providing clear feedback and functionality.
Changes Made
Filter Functionality:
"Not Available" Message:
Added content for the following treks:
Screenshot
Video
repo.mp4
Related Issues