Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/support proxy for freshclam #20

Closed

Conversation

asteel-gsa
Copy link

PR for #19

Test Case (with ajilaag/clamav-rest image):

/etc/clamav # ./test.sh 
Replaced proxy server #=> ensuring sed works with new delimiter when testing
Replaced proxy port #=> ensuring sed works with new delimiter when testing
Replaced proxy user and pass #=> ensuring sed works with new delimiter when testing

/etc/clamav # cat freshclam.conf | grep "HTTP*"
# The HTTPProxyServer may be prefixed with [scheme]:// to specify which kind
#   http://     HTTP Proxy. Default when no scheme or proxy type is specified.
#   https://    HTTPS Proxy. (Added in 7.52.0 for OpenSSL, GnuTLS and NSS)
HTTPProxyServer https://proxy-test.com
HTTPProxyPort 54321
HTTPProxyUsername TESTUSER
HTTPProxyPassword TEST/PASS
#HTTPUserAgent SomeUserAgentIdString

Usage:
If $PROXY_SERVER is not set in an environment variable, then none of this will run
If $PROXY_SERVER is set then replace the value in freshclam.conf

  • Since port, username and password are not required, only apply them to freshclam.conf if $PROXY_PORT, $PROXY_USERNAME and $PROXY_PASSWORD are set in an environment variable

@asteel-gsa asteel-gsa marked this pull request as ready for review May 9, 2023 18:29
@mogul
Copy link

mogul commented May 19, 2023

@rhermanek would you mind merging this for us? We're hoping to avoid maintaining our own image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants