Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(quality): ♻️ rewrite compareTo without relying on runtimeType #594

Merged

Conversation

albertms10
Copy link
Owner

No description provided.

…Type`

Signed-off-by: Albert Mañosa <26429103+albertms10@users.noreply.github.com>
@albertms10 albertms10 added the refactor The code needs to be refactored label Feb 22, 2025
@albertms10 albertms10 added this to the Road to 0.22 milestone Feb 22, 2025
@albertms10 albertms10 self-assigned this Feb 22, 2025
@albertms10 albertms10 merged commit 2c5d5b9 into main Feb 22, 2025
2 checks passed
@albertms10 albertms10 deleted the refactor/rewrite-compare-to-without-relying-on-runtime-type branch February 22, 2025 14:50
@coveralls
Copy link

Pull Request Test Coverage Report for Build 13473932105

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.08%) to 99.925%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/src/interval/quality.dart 3 4 75.0%
Totals Coverage Status
Change from base Build 13473917066: -0.08%
Covered Lines: 1337
Relevant Lines: 1338

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor The code needs to be refactored
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants