fix: close OAuth popup from parent #973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On iOS, a browser window can't close itself via `window.close()`: instead, it must be closed by the same context that called `window.open` to open it. This means that for iOS we cannot rely on the OAuth callback window to close itself in the popup-based flow. Instead, we'll have the parent close it upon receiving a message.
dphilipson
requested review from
moldy530,
rthomare,
dancoombs and
mokok123
as code owners
|
You must have Developer access to commit code to Alchemy on Vercel. If you contact an administrator and receive Developer access, commit again to see your changes. Learn more: https://vercel.com/docs/accounts/team-members-and-roles/access-roles#team-level-roles |
rthomare
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS, a browser window can't close itself via
window.close(): instead, it must be closed by the same context that calledwindow.opento open it. This means that for iOS we cannot rely on the OAuth callback window to close itself in the popup-based flow. Instead, we'll have the parent close it upon receiving a message.PR-Codex overview
This PR adds a line of code to close a popup window when
bundleandorgIdare present.Detailed summary
popup?.close()to close the popup window whenbundleandorgIdare present.