Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close OAuth popup from parent #973

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix: close OAuth popup from parent #973

merged 1 commit into from
Sep 20, 2024

Commits on Sep 19, 2024

  1. fix: close OAuth popup from parent 

    On iOS, a browser window can't close itself via `window.close()`:
instead, it must be closed by the same context that called `window.open`
to open it. This means that for iOS we cannot rely on the OAuth callback
window to close itself in the popup-based flow. Instead, we'll have the
parent close it upon receiving a message.
    @dphilipson
    dphilipson committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    3d73ab1 View commit details
    Browse the repository at this point in the history