Gas and fees #36
Closed
Gas and fees #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 10, 2024 09:44
ultrasecreth
requested changes
Apr 10, 2024
Comment on lines
+147
to
+149
| uint256 startingGas = gasleft(); | ||
| out = lender.flash(address(loanReceiver), asset, amount, "", this.onFlashLoan); | ||
| uint256 endingGas = gasleft(); |
There was a problem hiding this comment.
I think it'd be better to use something like https://github.com/marktoda/forge-gas-snapshot
There was a problem hiding this comment.
I can do that, do you want to block this until I get the time? Happy either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gas from each lender is simply calculated by wrapping
flashLoaningasleft(), and discounting the gas cost of the instructions in the callback.The fees are extracted from tests and documentation.