Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas and fees #36

Closed
wants to merge 3 commits into from
Closed

Gas and fees #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf7ea80
gas and fees
Apr 10, 2024
6b13f41
lint
Apr 10, 2024
74ff984
fixed fees and removed registry mentions
Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 23 additions & 26 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,32 +26,29 @@ sequenceDiagram
† For the BalancerWrapper and Uniswap v3 the borrower transfers the repayment to the lender and the wrapper skips the
repayment approval.

## Addresses

Contracts are deployed at the same address for all supported networks.

| Contract | Lender | Address | Networks |
| ------------------------------------------------------------- | ------------------- | ------------------------------------------ | ------------------------------------------------- |
| [AaveWrapper](src/aave/AaveWrapper.sol) | Aave v3 | 0x9D4D2C08b29A2Db1c614483cd8971734BFDCC9F2 | Arbitrum One, Optimism, Polygon |
| [AaveWrapper](src/aave/AaveWrapper.sol) | Aave v3 | 0x0c86c636ed5593705b5675d370c831972C787841 | Ethereum, Gnosis |
| [AaveWrapper](src/aave/AaveWrapper.sol) | Spark | 0x8cB701df93f2Dae295aE8D7beE5Aa7e4D40CB397 | Ethereum, Gnosis |
| [BalancerWrapper](src/balancer/BalancerWrapper.sol) | Balancer v2 | 0x9E092cb431e5F1aa70e47e052773711d2Ba4917E | Ethereum, Arbitrum One, Optimism, Polygon, Gnosis |
| [BalancerWrapper](src/balancer/BalancerWrapper.sol) | Balancer v2 | 0xD534400B0555F8441c5a3e0E9e585615B54fB2F4 | Base |
| [UniswapV3Wrapper](src/uniswapV3/UniswapV3Wrapper.sol) | Uniswap v3 | 0x319300462C37AD2D4f26B584C2b67De51F51f289 | Arbitrum One, Optimism, Polygon |
| [CompoundWrapper](src/compound/CompoundWrapper.sol) | Balancer + Moonwell | 0x6207ec38da68902CC60D3760c9fe3EB64B426207 | Base |
| [CompoundWrapper](src/compound/CompoundWrapper.sol) | Balancer + Sonne | 0x6412183C579a276f467ad38468D19CC8f1F2b5cb | Optimism |
| [SiloWrapper](src/silo/SiloWrapper.sol) | Balancer + Silo | 0x0F9104Fec1a5C91e63632E215e8F5c57C8f32c77 | Arbitrum One |
| [DolomiteWrapper](src/dolomite/DolomiteWrapper.sol) | Dolomite | 0x54F1ce5E6bdf027C9a6016C9F52fC5A445b77ed6 | Arbitrum One |
| [MorphoBlueWrapper](src/morpho/MorphoBlueWrapper.sol) | MorphoBlue | 0xa0Cb4e1222d813D6e4dE79f2A7A0B7759209588F | Ethereum |
| [AlgebraWrapper](src/algebra/DolomiteWrapper.sol) | Camelot | 0x5E8820B2832aD8451f65Fa2CCe2F3Cef29016D0d | Arbitrum One |
| [AlgebraPendleWrapper](src/pendle/AlgebraPendleWrapper.sol) | Algebra + Pendle | 0xC9d66F655b7B35A2B4958bE2FB58E472736Bbc47 | Arbitrum One |
| [BalancerPendleWrapper](src/pendle/BalancerPendleWrapper.sol) | Balancer + Pendle | 0xC1Ea6a6df39D991006b39706db7C51f5A1819da7 | Arbitrum One |
| [SolidlyWrapper](src/solidly/SolidlyWrapper.sol) | Aerodrome | 0x69b6E55f00d908018E2D745c524995bc231D762b | Base |
| [SolidlyWrapper](src/solidly/SolidlyWrapper.sol) | Velodrome | 0xcF13CDdbA3aEf757c52466deC310F221e06238d6 | Optimism |

When a contract requires constructor parameters which vary per network, these are supplied by the
[Registry](https://github.com/alcueca/registry) deployed at 0x1BFf8Eee6ECF1c8155E81dba8894CE9cF49a220c in each supported
network.
## Deployments

| Lender | Networks | Address | Gas | Fees | Contract |
| ---------------------- | ------------------------------------------------- | ------------------------------------------ | --------------- | -------- | ------------------------------------------------------------- |
| Aave v3 | Arbitrum One, Optimism, Polygon | 0x9D4D2C08b29A2Db1c614483cd8971734BFDCC9F2 | 302483 | 0.05% | [AaveWrapper](src/aave/AaveWrapper.sol) |
| Aave v3 (Permissioned) | Ethereum, Gnosis | 0x0c86c636ed5593705b5675d370c831972C787841 | 299756 | 0 | [AaveWrapper](src/aave/AaveWrapper.sol) |
| Spark | Ethereum, Gnosis | 0x8cB701df93f2Dae295aE8D7beE5Aa7e4D40CB397 | 302483 | 0 | [AaveWrapper](src/aave/AaveWrapper.sol) |
| Balancer v2 | Ethereum, Arbitrum One, Optimism, Polygon, Gnosis | 0x9E092cb431e5F1aa70e47e052773711d2Ba4917E | 183039 | 0 | [BalancerWrapper](src/balancer/BalancerWrapper.sol) |
| Balancer v2 | Base | 0xD534400B0555F8441c5a3e0E9e585615B54fB2F4 | 183039 | 0 | [BalancerWrapper](src/balancer/BalancerWrapper.sol) |
| Uniswap v3 | Arbitrum One, Optimism, Polygon | 0x319300462C37AD2D4f26B584C2b67De51F51f289 | 184417 - 202711 | Variable | [UniswapV3Wrapper](src/uniswapV3/UniswapV3Wrapper.sol) |
| Balancer + Moonwell | Base | 0x6207ec38da68902CC60D3760c9fe3EB64B426207 | 1253325 | 0 | [CompoundWrapper](src/compound/CompoundWrapper.sol) |
| Balancer + Sonne | Optimism | 0x6412183C579a276f467ad38468D19CC8f1F2b5cb | 1142829 | 0 | [CompoundWrapper](src/compound/CompoundWrapper.sol) |
| Balancer + Silo | Arbitrum One | 0x0F9104Fec1a5C91e63632E215e8F5c57C8f32c77 | 1115741 | 1 | [SiloWrapper](src/silo/SiloWrapper.sol) |
| Dolomite | Arbitrum One | 0x54F1ce5E6bdf027C9a6016C9F52fC5A445b77ed6 | 529843 | 0 | [DolomiteWrapper](src/dolomite/DolomiteWrapper.sol) |
| MorphoBlue | Ethereum | 0xa0Cb4e1222d813D6e4dE79f2A7A0B7759209588F | 202128 | 0 | [MorphoBlueWrapper](src/morpho/MorphoBlueWrapper.sol) |
| Camelot | Arbitrum One | 0x5E8820B2832aD8451f65Fa2CCe2F3Cef29016D0d | 148686 - 155940 | 0.01% | [AlgebraWrapper](src/algebra/AlgebraWrapper.sol) |
| Algebra + Pendle | Arbitrum One | 0xC9d66F655b7B35A2B4958bE2FB58E472736Bbc47 | 596718 | 0.01% | [AlgebraPendleWrapper](src/pendle/AlgebraPendleWrapper.sol) |
| Balancer + Pendle | Arbitrum One | 0xC1Ea6a6df39D991006b39706db7C51f5A1819da7 | 595448 | 0 | [BalancerPendleWrapper](src/pendle/BalancerPendleWrapper.sol) |
| Aerodrome | Base | 0x69b6E55f00d908018E2D745c524995bc231D762b | 253829 - 314321 | Variable | [SolidlyWrapper](src/solidly/SolidlyWrapper.sol) |
| Velodrome | Optimism | 0xcF13CDdbA3aEf757c52466deC310F221e06238d6 | 253829 - 314321 | Variable | [SolidlyWrapper](src/solidly/SolidlyWrapper.sol) |

Approximate gas costs and fees are provided. For AMMs the fees often vary according to pool parameters and state. Gas
costs can also vary according to state.

## Flash Loans

Expand Down
2 changes: 2 additions & 0 deletions test/AaveWrapper.v2.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,8 @@ contract AaveWrapperTest is Test {
assertEq(borrower.flashBalance(), loan + fee); // The amount we transferred to pay for fees, plus the amount we
// borrowed
assertEq(borrower.flashFee(), fee);

console2.log("Aave v2: ", borrower.usedGas());
}

function test_executeOperation_permissions() public {
Expand Down
2 changes: 2 additions & 0 deletions test/AaveWrapper.v3.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ contract AaveWrapperTest is Test {
assertEq(borrower.flashBalance(), loan + fee); // The amount we transferred to pay for fees, plus the amount we
// borrowed
assertEq(borrower.flashFee(), fee);

console2.log("Aave v3: ", borrower.usedGas());
}

function test_executeOperation_permissions() public {
Expand Down
2 changes: 2 additions & 0 deletions test/AlgebraPendleWrapper.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ contract AlgebraPendleWrapperTest is Test {
wrapper.retrieve(IERC20(token), treasury, 0.001e18);
assertEqDecimal(IERC20(token).balanceOf(treasury), 0.001e18, 18, "Fee not transferred");
assertEqDecimal(IERC20(token).balanceOf(address(wrapper)), 0, 18, "Fee still in wrapper");

console2.log("Algebra + Pendle: ", borrower.usedGas());
}

function testRetrievePermissions() public {
Expand Down
2 changes: 2 additions & 0 deletions test/AlgebraWrapper.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,8 @@ contract AlgebraWrapperTest is Test {
// The amount we transferred to pay for fees, plus the amount we borrowed
assertEq(borrower.flashBalance(), loan + fee, "flashBalance");
assertEq(borrower.flashFee(), fee, "flashFee");

console2.log("Algebra: ", borrower.usedGas());
}

function test_AlgebraFlashCallback_permissions() public {
Expand Down
2 changes: 2 additions & 0 deletions test/BalancerPendleWrapper.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ contract BalancerPendleWrapperTest is Test {
assertEq(borrower.flashBalance(), loan + fee); // The amount we transferred to pay for fees, plus the amount we
// borrowed
assertEq(borrower.flashFee(), fee);

console2.log("Balancer + Pendle: ", borrower.usedGas());
}

function test_receiveFlashLoan_permissions() public {
Expand Down
2 changes: 2 additions & 0 deletions test/BalancerWrapper.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,8 @@ contract BalancerWrapperTest is Test {
assertEq(borrower.flashBalance(), loan + fee); // The amount we transferred to pay for fees, plus the amount we
// borrowed
assertEq(borrower.flashFee(), fee);

console2.log("Balancer: ", borrower.usedGas());
}

function test_receiveFlashLoan_permissions() public {
Expand Down
2 changes: 2 additions & 0 deletions test/CompoundWrapper.Moonwell.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ contract MoonwellWrapperTest is Test {
assertEq(borrower.flashBalance(), loan + fee); // The amount we transferred to pay for fees, plus the amount we
// borrowed
assertEq(borrower.flashFee(), fee);

console2.log("Compound/Moonwell: ", borrower.usedGas());
}

function test_receiveFlashLoan_permissions() public {
Expand Down
2 changes: 2 additions & 0 deletions test/CompoundWrapper.Sonne.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ contract SonneWrapperTest is Test {
assertEq(borrower.flashBalance(), loan + fee); // The amount we transferred to pay for fees, plus the amount we
// borrowed
assertEq(borrower.flashFee(), fee);

console2.log("Compound/Sonne: ", borrower.usedGas());
}

function test_receiveFlashLoan_permissions() public {
Expand Down
2 changes: 2 additions & 0 deletions test/CompoundWrapper.erc20.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ contract CompoundWrapperTest is Test {
assertEq(borrower.flashBalance(), loan + fee); // The amount we transferred to pay for fees, plus the amount we
// borrowed
assertEq(borrower.flashFee(), fee);

console2.log("Compound: ", borrower.usedGas());
}

function test_receiveFlashLoan_permissions() public {
Expand Down
2 changes: 2 additions & 0 deletions test/CompoundWrapper.native.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,8 @@ contract CompoundWrapperTest is Test {
assertEq(borrower.flashBalance(), loan + fee); // The amount we transferred to pay for fees, plus the amount we
// borrowed
assertEq(borrower.flashFee(), fee);

console2.log("Compound Native: ", borrower.usedGas());
}

function test_receiveFlashLoan_permissions() public {
Expand Down
2 changes: 2 additions & 0 deletions test/DolomiteWrapper.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,8 @@ contract DolomiteWrapperTest is Test {
assertEq(borrower.flashBalance(), loan + fee); // The amount we transferred to pay for fees, plus the amount we
// borrowed
assertEq(borrower.flashFee(), fee);

console2.log("Dolomite: ", borrower.usedGas());
}

function test_receiveFlashLoan_permissions() public {
Expand Down
2 changes: 2 additions & 0 deletions test/ERC3156Wrapper.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,5 +72,7 @@ contract ERC3156WrapperTest is Test {
assertEq(borrower.flashBalance(), loan + fee); // The amount we transferred to pay for fees, plus the amount we
// borrowed
assertEq(borrower.flashFee(), fee);

console2.log("ERC3156: ", borrower.usedGas());
}
}
13 changes: 11 additions & 2 deletions test/MockBorrower.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ pragma solidity ^0.8.19;

import "erc7399/IERC7399.sol";
import "src/BaseWrapper.sol";
import { console2 } from "forge-std/console2.sol";

contract LoanReceiver {
using SafeERC20 for IERC20;
Expand All @@ -25,6 +26,8 @@ contract MockBorrower {
address public flashAsset;
uint256 public flashAmount;
uint256 public flashFee;
uint256 public innerGas;
uint256 public usedGas;

constructor(IERC7399 lender_) {
setLender(lender_);
Expand All @@ -47,6 +50,7 @@ contract MockBorrower {
external
returns (bytes memory)
{
uint256 startingGas = gasleft();
require(msg.sender == address(lender), "MockBorrower: Untrusted lender");
require(initiator == address(this), "MockBorrower: External loan initiator");

Expand All @@ -56,6 +60,8 @@ contract MockBorrower {
flashFee = fee;
loanReceiver.retrieve(asset);
flashBalance = IERC20(asset).balanceOf(address(this));

innerGas = startingGas - gasleft(); // Transferring the repayment is counted towards the flash loan cost
IERC20(asset).safeTransfer(paymentReceiver, amount + fee);

return abi.encode(ERC3156PP_CALLBACK_SUCCESS);
Expand Down Expand Up @@ -137,8 +143,11 @@ contract MockBorrower {
return "";
}

function flashBorrow(address asset, uint256 amount) public returns (bytes memory) {
return lender.flash(address(loanReceiver), asset, amount, "", this.onFlashLoan);
function flashBorrow(address asset, uint256 amount) public returns (bytes memory out) {
uint256 startingGas = gasleft();
out = lender.flash(address(loanReceiver), asset, amount, "", this.onFlashLoan);
uint256 endingGas = gasleft();
Comment on lines +147 to +149
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it'd be better to use something like https://github.com/marktoda/forge-gas-snapshot

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can do that, do you want to block this until I get the time? Happy either way.

usedGas = startingGas - endingGas - innerGas;
}

function flashBorrowNoPointers(address asset, uint256 amount) public returns (bytes memory) {
Expand Down
2 changes: 2 additions & 0 deletions test/MorphoBlueWrapper.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ contract MorphoBlueWrapperTest is Test {
assertEq(borrower.flashBalance(), loan + fee); // The amount we transferred to pay for fees, plus the amount we
// borrowed
assertEq(borrower.flashFee(), fee);

console2.log("Morpho Blue: ", borrower.usedGas());
}

function test_onMorphoFlashLoan_permissions() public {
Expand Down
2 changes: 2 additions & 0 deletions test/PermissionedAaveWrapper.v3.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,8 @@ contract PermissionedAaveWrapperTest is Test {
assertEq(borrower.flashBalance(), loan + fee); // The amount we transferred to pay for fees, plus the amount we
// borrowed
assertEq(borrower.flashFee(), fee);

console2.log("Aave v3 (Permissioned): ", borrower.usedGas());
}

function test_executeOperation_permissions() public {
Expand Down
2 changes: 2 additions & 0 deletions test/SiloWrapper.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,8 @@ contract SiloWrapperTest is Test {
assertEq(borrower.flashFee(), fee);

assertEq(intermediateToken.balanceOf(address(wrapper)), dust - 1, "Too much dust spent");

console2.log("Silo: ", borrower.usedGas());
}

function test_receiveFlashLoan_permissions() public {
Expand Down
2 changes: 2 additions & 0 deletions test/SolidlyWrapper.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,8 @@ contract SolidlyWrapperTest is Test {
// The amount we transferred to pay for fees, plus the amount we borrowed
assertEq(borrower.flashBalance(), loan + fee, "flashBalance");
assertEq(borrower.flashFee(), fee, "flashFee");

console2.log("Solidly: ", borrower.usedGas());
}

function test_SolidlyFlashCallback_permissions() public {
Expand Down
2 changes: 2 additions & 0 deletions test/UniswapV3Wrapper.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,8 @@ contract UniswapV3WrapperTest is Test {
// The amount we transferred to pay for fees, plus the amount we borrowed
assertEq(borrower.flashBalance(), loan + fee, "flashBalance");
assertEq(borrower.flashFee(), fee, "flashFee");

console2.log("Uniswap v3: ", borrower.usedGas());
}

function test_uniswapV3FlashCallback_permissions() public {
Expand Down
Loading