Return a Pathname from the file helper#70
Merged
adamstegman merged 1 commit intoalexrothenberg:mainfrom Dec 4, 2023
Merged
Conversation
Otherwise, warnings were printed when the return value of the `file`
helper was used with the `exist` matcher:
```ruby
subject { file('posts_spec.rb') }
it { is_expected.to exist }
```
This was referenced Dec 4, 2023
adamstegman
approved these changes
Dec 4, 2023
Collaborator
adamstegman
left a comment
adamstegman
left a comment
There was a problem hiding this comment.
Thanks! This is a nice cleanup.
|
Could we have a release with this fix? 🙏 The deprecation noise is flooding our logs. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise, warnings were printed when the return value of the
filehelper was used with theexistmatcher:Follow-up to #68
Other CI failures are unrelated, also present on
main(see this PR).