feat: convert meta-checks to decorators #1188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1188 +/- ##
==========================================
+ Coverage 94.40% 94.44% +0.03%
==========================================
Files 83 83
Lines 1162 1170 +8
==========================================
+ Hits 1097 1105 +8
Misses 65 65
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
suchow
previously requested changes
Jul 6, 2021
Contributor
suchow
left a comment
suchow
left a comment
There was a problem hiding this comment.
Rather than implementing this as a meta-check, I think we should either:
- Create a decorator
@thresholdthat takes a parameter specifying the threshold ppm below above which errors will be flagged. - Do what we are currently doing with
max_errorsvia thetruncate_to_maxfunction.
I think I'd put in a vote for making both threshold and max_errors decorators that would work for all check types.
Nytelife26
force-pushed
the
feat/threshold-check
branch
2 times, most recently
from
1c13437 to
a9a68fc
Compare
Nytelife26
force-pushed
the
feat/threshold-check
branch
from
a9a68fc to
d869639
Compare
Nytelife26
force-pushed
the
feat/threshold-check
branch
from
d869639 to
b4e4dda
Compare
This was referenced Aug 22, 2021
Nytelife26
force-pushed
the
feat/threshold-check
branch
from
b4e4dda to
d51501d
Compare
Nytelife26
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Adding threshold checks. This blocks #802. This is blocked by #1217 and #1218.
Rationale
This is useful for situations such as in
checks.typography.exclamation.30ppmwhere a PPM threshold metricdetermines whether to raise an error or not.
Changes
tools.threshold_checkchecks.typography.exclamationto usethreshold_checkFeatures
tools.threshold_checkBug Fixes
N/A.
Breaking Changes and Deprecations
N/A.