Skip to content

Conversation

@Nytelife26
Copy link
Contributor

@Nytelife26 Nytelife26 commented Aug 22, 2021

This relates to...

Converting truncate_to_max to a decorator as a meta-check. This blocks #1188.

Changes

  • convert max_errors to a decorator

Features

  • export max_errors check decorator

Bug Fixes

N/A.

Breaking Changes and Deprecations

N/A.

@Nytelife26 Nytelife26 requested a review from suchow as a code owner August 22, 2021 21:47
@Nytelife26 Nytelife26 added cat: maintenance type: refactor A change that does not fix a bug or add a feature labels Aug 22, 2021
@codecov
Copy link

codecov bot commented Aug 22, 2021

Codecov Report

Merging #1218 (9f4f740) into main (1d1e7cf) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1218      +/-   ##
==========================================
+ Coverage   94.31%   94.40%   +0.08%     
==========================================
  Files          83       83              
  Lines        1144     1161      +17     
==========================================
+ Hits         1079     1096      +17     
  Misses         65       65              
Flag Coverage Δ
macos-latest 94.40% <100.00%> (+0.08%) ⬆️
py3.6 93.82% <100.00%> (+0.09%) ⬆️
py3.7 93.82% <100.00%> (+0.09%) ⬆️
py3.8 94.40% <100.00%> (+0.08%) ⬆️
py3.9 94.40% <100.00%> (+0.08%) ⬆️
pypypy3 93.82% <100.00%> (+0.09%) ⬆️
ubuntu-latest 94.40% <100.00%> (+0.08%) ⬆️
windows-latest 94.40% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
proselint/checks/cliches/hell.py 100.00% <100.00%> (ø)
proselint/checks/misc/pretension.py 100.00% <100.00%> (ø)
proselint/checks/misc/suddenly.py 100.00% <100.00%> (ø)
proselint/checks/mixed_metaphors/misc.py 100.00% <100.00%> (ø)
proselint/checks/typography/exclamation.py 100.00% <100.00%> (ø)
proselint/checks/typography/symbols.py 100.00% <100.00%> (ø)
proselint/checks/weasel_words/very.py 100.00% <100.00%> (ø)
proselint/tools.py 86.86% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d1e7cf...9f4f740. Read the comment docs.

@Nytelife26 Nytelife26 changed the title convert max_errors to decorator refactor: convert max_errors to decorator Nov 6, 2021
@Nytelife26 Nytelife26 merged commit ef6f77d into main Nov 6, 2021
@Nytelife26 Nytelife26 deleted the refactor/metacheck-decorators branch November 6, 2021 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: refactor A change that does not fix a bug or add a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant