Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'master' branch references with 'main' #1238

Merged
merged 2 commits into from
Jan 16, 2024
Merged

Conversation

IuliaCMoldovan
Copy link
Contributor

@IuliaCMoldovan IuliaCMoldovan commented Dec 14, 2023

PR Description

Replaced all the references to master branch with main. This includes all the license headers, the guideline checker action that checks for the appropriate license header format, the main README of the repo, the Building an HDL project doc page and in other places where links were referenced.

Changed the link to the software downloads site to have the files built from main and from the latest release. As it is now on main, the link is invalid (returns "not found").
In Building an HDL project documentation page, there were full links used, not with :git-hdl: role and it was using the master branch.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

StancaPop
StancaPop previously approved these changes Dec 14, 2023
Copy link
Contributor

@StancaPop StancaPop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

gastmaier
gastmaier previously approved these changes Dec 14, 2023
Copy link
Contributor

@gastmaier gastmaier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@@ -110,7 +110,7 @@ ENDFIELD
REG
0x0007
FPGA_INFO
FPGA device information [[https://github.com/analogdevicesinc/hdl/blob/master/library/scripts/adi_xilinx_device_info_enc.tcl |Xilinx encoded values]]
FPGA device information [[https://github.com/analogdevicesinc/hdl/blob/main/library/scripts/adi_xilinx_device_info_enc.tcl |Xilinx encoded values]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to myself: when importing this documentation, update the regmap link to sphinx style.

AndreiGrozav
AndreiGrozav previously approved these changes Dec 15, 2023
Signed-off-by: Iulia Moldovan <Iulia.Moldovan@analog.com>
* README.md
* adi_regmap_xcvr.txt
* build_hdl.rst
* hdl_coding_guideline.rst
* data_offload/README.md

Signed-off-by: Iulia Moldovan <Iulia.Moldovan@analog.com>
@IuliaCMoldovan
Copy link
Contributor Author

Rebased and resolved the conflicts that occurred with deleted files from library/axi_pwm_gen

Copy link
Contributor

@LBFFilho LBFFilho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@IuliaCMoldovan IuliaCMoldovan merged commit b45e7a7 into main Jan 16, 2024
1 of 3 checks passed
@IuliaCMoldovan IuliaCMoldovan deleted the replace_master branch January 16, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmetics The changes are not functional. doc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants