Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/axi_pwm_gen: Update ext_sync-related axi_pwm_gen's logic #1259

Closed
wants to merge 1 commit into from

Conversation

alin724
Copy link
Contributor

@alin724 alin724 commented Jan 26, 2024

PR Description

New operation mode for the external synchronization:
External synchronization using a signal that is based on a faster clock (also compatible with slower clock than the ext_clk or axi_clk of the axi_pwm_gen module) + without using the load_config register (continuous offset-related synchronization - e.g. synchronization at 1 s by using a 1 Hz sync signal).

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@IuliaCMoldovan
Copy link
Contributor

Please update the copyright year of all files to contain 2024 as well

…based synchronization

New mode: External synchronization using a signal that
is based on a faster clock than the one of the axi_pwm_gen logic +
without using the load_config register (continous offset-related
synchronization - e.g. synchronization at 1 s by using a 1 Hz sync signal)

Signed-off-by: Alin-Tudor Sferle <Alin-Tudor.Sferle@analog.com>
@alin724 alin724 force-pushed the dev_pwm_gen_ext_sync_updates branch from 05598f6 to 2dd5f96 Compare February 2, 2024 08:48
@alin724
Copy link
Contributor Author

alin724 commented Feb 2, 2024

V2:

  • Updated the copyright year of pwm_gen lib's files to current year;

@alin724
Copy link
Contributor Author

alin724 commented Apr 25, 2024

Update:

  • can be closed for now [the implementation using 2 different cases for external sync pin of the axi_pwm_gen module [one when the ext_sync will come from a faster clock and will be used to align pwm_data to it and the second one that is from a clock that is lower and multiple of core clk] [ext_sync used with the same clock or clock lower and multiple of core_clk + using additional params [start_at_sync,ext_sync_align] from the following PR - axi_pwm_gen: New features based on parameters #1299]

@alin724 alin724 closed this Apr 25, 2024
@alin724 alin724 deleted the dev_pwm_gen_ext_sync_updates branch April 25, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants