Fix Windows Builds #1183
Fix Windows Builds #1183
Conversation
previously, deps compiled with mingw were used to build for MSVC added a new archive with deps compiled for MSVC to be used in this case added condition in build_win script to check for compiler and updated cmake paths for MSVC case Signed-off-by: Cristina Suteu <cristina.suteu@analog.com>
extract and copy MSVC deps to BUILD_ARTIFACTSTAGINGDIRECTORY update name of libserialport.dll in iss file Signed-off-by: Cristina Suteu <cristina.suteu@analog.com>
cristina-suteu
requested review from
dNechita,
mhennerich,
SRaus and
AAndrisa
as code owners
| @@ -9,7 +9,10 @@ cd $src_dir | |||
| mkdir dependencies | |||
| cd dependencies | |||
| wget http://swdownloads.analog.com/cse/build/libiio-deps-20220517.zip -OutFile "libiio-win-deps.zip" | |||
| wget https://swdownloads.analog.com/cse/build/libiio-deps-20240627.zip -OutFile "libiio-msvc-deps.zip" | |||
There was a problem hiding this comment.
It would help (in the future) to rename libiio-deps-20200627 to a name that doesn't change over time. For example: libiio-deps-msvc. If at some point in time, there will be a new libiio-deps-yyyymmdd ,then there will be only one place to update the name. Now there are extra 4 places besides this one.
There was a problem hiding this comment.
i used the yyyy-mm-dd format, to match the naming used in the other archive.
as a side note, the old archive with mingw compiled deps should also be updated to contain all required files. would it make sense to update the names of both archives to leave out the yyyy-mm-dd suffix after fixing the mingw archive as well ?
|
As things was before - was sort of fragile and is sort of iffy from a licensing standpoint... replicating it might not be the right path forward. |
I agree. We should provide the complete build recipe for deps and libiio itself. The purpose of this PR is to fix the issue which was reported. This is more of a hot-fix, than a long term solution, so people can download and use the windows installers. If this is not that urgent, I can close this and address this issue and the entire build recipe in a different PR. |
|
Providing the complete build would address the licensing issue. The installer probably needs to be checked that it does reference anything packaged as well |
|
I think this is replaced by #1197 and this can be closed (without merging)? |
PR Description
As things was before, for the windows deps an archive was downloaded from swdownloads. Said archive contains windows deps compiled with MinGW. The installer is created based on the MSVC builds. Both MSVC and MinGW builds were using deps from this archive compiled with MinGW. While the project seemed to be building okay, this caused problems which were visible in both installer and MSVC libiio zips at runtime.
By adding a new archive with deps compiled with MSVC to be used when building libiio with MSVC, the issue is resolved.
Moreover, a check for the compiler used was added in the windows build script. This ensures the correct paths to libiio's deps according to the compiler used.
This fixes issue #1174
PR Type
PR Checklist