Windows dependencies build #1197

AAndrisa · 2024-09-12T12:32:12Z

PR Description

In the old flow the needed dependencies were downloaded from a zip, and for msvc and mingw compiler were used the same files.
Now each compiler has its own specific dependencies.
Artifact manifest was updated and also publish deps script with the corresponding paths of the new files.
This PR is related to #1183

PR Type

Bug fix (a change that fixes an issue)
New feature (a change that adds new functionality)
Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

I have conducted a self-review of my own code changes
I have commented new code, particulary complex or unclear areas
I have checked that I did not intoduced new warnings or errors (CI output)
I have checked that components that use libiio did not get broken
I have updated the documentation accordingly (GitHub Pages, READMEs, etc)

rgetz

in general - this looks great. Thanks

I think you need to distribute the source of the dependencies to be license complainant. (not just the dlls). Although - I don't see the point in doing this in a giant tar - just in the source tar, the dependencies should be there as well.

plus - don't forget to fix the Codacy issue pointed out.

-Robin

rgetz · 2024-09-13T14:06:50Z

CI/azure/windows_build_deps.cmd

+FOR /F "USEBACKQ TOKENS=*" %%F IN (`%vswhere% !vswhere_params! -requires Microsoft.Component.MSBuild -find MSBuild\**\Bin\MSBuild.exe`) DO (
+SET msbuild="%%F"
+)
+:: clone the zstd repo and build it with the desierd configuration


desierd

should be desired? (spelling)

rgetz · 2024-09-13T14:10:10Z

CI/azure/windows_build_deps.cmd

+cmake --build libxml2-build --config Release --target install
+
+:: clone and build libserialport project
+git clone https://github.com/sigrokproject/libserialport.git


for other repos - you are getting specific versions. for libserialport - you are grabbing tip of master - is that what you want to do? (I'm not sure there is a better idea, since the newest release is so old)...

Another idea would be to specifically git checkout a commit from the master branch, in case other commits will be added in which case that might brake things for us. (if this is not ok, I will leave it as it is)

considering a release was just done (last week) - maybe that's what you should point to?

https://github.com/sigrokproject/libserialport/tree/libserialport-0.1.2

AAndrisa · 2024-09-25T07:15:11Z

in general - this looks great. Thanks

I think you need to distribute the source of the dependencies to be license complainant. (not just the dlls). Although - I don't see the point in doing this in a giant tar - just in the source tar, the dependencies should be there as well.

plus - don't forget to fix the Codacy issue pointed out.

-Robin

In the source tar should be included just the source code of the built dependencies?

tfcollins · 2024-10-02T21:18:36Z

in general - this looks great. Thanks
I think you need to distribute the source of the dependencies to be license complainant. (not just the dlls). Although - I don't see the point in doing this in a giant tar - just in the source tar, the dependencies should be there as well.
plus - don't forget to fix the Codacy issue pointed out.
-Robin

In the source tar should be included just the source code of the built dependencies?

Yes and build scripts used so others can repeat.

tfcollins

Besides the package for dependency source+build scripts this looks good

stephenkilbaneadi · 2024-10-08T15:33:18Z

CI/azure/windows_build_deps.cmd

+:: if is run from the root of the libiio project all the dependencies will be found in the deps folder of the project
+:: in case you already have some dependencies build just comment them in the script and during compilation of libiio specify the path
+:: export as environment variables the ARCH, PLATFORM_TOOLSET and COMPILER used for visual studio build
+:: ex: set ARCH=x64, PLATFROM_TOOLSET=v143 and COMPILER='Visual Studio 17 2022' for VS2022


Typo: PLATFROM_TOOLSET

AAndrisa · 2024-10-15T11:52:10Z

v2: update, add archive with the source code of the build dependencies for msvc build

rgetz

Looks good to me - thanks

(would still fix the Codacy issue though).

New flow for mingw builds on windows operating system is implemented by installing the nedeed dependencies and build libiio with the bash from msys2 that supports also mingw64. The dependencies will be installed with pacman. Signed-off-by: Andreea Andrisan <Andreea.Andrisan@analog.com>

With the new script added we can build libiio via msys2 bash using also dependencis installed with pacman. By removing the old dll files that were downloaded from an archive the paths to the dependencies needed to be modified and now they are copied from the mingw64 folder. Signed-off-by: Andreea Andrisan <Andreea.Andrisan@analog.com>

AAndrisa · 2024-10-22T08:36:12Z

v3: fix Codacy issue

This script will clone and download different dependencies of the libiio in order to build them with the msvc compiler. Using msbuild that is the visual studio program designed for terminal builds of visual studio projects. Signed-off-by: Andreea Andrisan <Andreea.Andrisan@analog.com>

Switch to new script and modify the paths form cmake command and also the path from where the dll files were copied. The old script build_win.ps1 was renamed in build_win_msvc.ps1 because now it supports just the msvc compiler, eliminating the support for mingw because was not needed anymore. Signed-off-by: Andreea Andrisan <Andreea.Andrisan@analog.com>

Export the source code of the build dependencies with msvc for the Windows build. Signed-off-by: Andreea Andrisan <Andreea.Andrisan@analog.com>

After new libraries build the nameing of some files was changed and also the file was not updated with the lates changes. Signed-off-by: Andreea Andrisan <Andreea.Andrisan@analog.com>

AAndrisa · 2024-10-22T13:45:55Z

v4: clone libserialport release

AAndrisa requested review from cristina-suteu, dNechita, mhennerich and SRaus as code owners September 12, 2024 12:32

rgetz reviewed Sep 13, 2024

View reviewed changes

rgetz mentioned this pull request Sep 13, 2024

Fix Windows Builds #1183

Closed

8 tasks

AAndrisa requested a review from tfcollins September 30, 2024 12:07

tfcollins approved these changes Oct 2, 2024

View reviewed changes

stephenkilbaneadi reviewed Oct 8, 2024

View reviewed changes

AAndrisa force-pushed the windows_dep branch 4 times, most recently from 37af5f9 to 07ad00e Compare October 15, 2024 11:24

AAndrisa requested review from rgetz and stephenkilbaneadi October 15, 2024 11:50

rgetz approved these changes Oct 18, 2024

View reviewed changes

AAndrisa added 2 commits October 22, 2024 10:33

AAndrisa force-pushed the windows_dep branch from 07ad00e to 4964f3e Compare October 22, 2024 08:25

SRaus approved these changes Oct 22, 2024

View reviewed changes

AAndrisa added 4 commits October 22, 2024 16:40

azure-pipelines.yml: export dependencies sources

98feb0d

Export the source code of the build dependencies with msvc for the Windows build. Signed-off-by: Andreea Andrisan <Andreea.Andrisan@analog.com>

artifact_manifest.txt.cmakein: update artifact manifest

e8410d6

After new libraries build the nameing of some files was changed and also the file was not updated with the lates changes. Signed-off-by: Andreea Andrisan <Andreea.Andrisan@analog.com>

AAndrisa force-pushed the windows_dep branch from 4964f3e to e8410d6 Compare October 22, 2024 13:44

AAndrisa merged commit 790a6c9 into main Oct 23, 2024
24 checks passed

AAndrisa deleted the windows_dep branch October 23, 2024 18:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Windows dependencies build #1197

Windows dependencies build #1197

AAndrisa commented Sep 12, 2024

rgetz left a comment •

edited

Loading

rgetz Sep 13, 2024

rgetz Sep 13, 2024

AAndrisa Sep 25, 2024 •

edited

Loading

rgetz Oct 22, 2024

AAndrisa commented Sep 25, 2024 •

edited

Loading

tfcollins commented Oct 2, 2024

tfcollins left a comment

stephenkilbaneadi Oct 8, 2024

AAndrisa commented Oct 15, 2024

rgetz left a comment •

edited

Loading

AAndrisa commented Oct 22, 2024

AAndrisa commented Oct 22, 2024

Windows dependencies build #1197

Windows dependencies build #1197

Conversation

AAndrisa commented Sep 12, 2024

PR Description

PR Type

PR Checklist

rgetz left a comment • edited Loading

Choose a reason for hiding this comment

rgetz Sep 13, 2024

Choose a reason for hiding this comment

rgetz Sep 13, 2024

Choose a reason for hiding this comment

AAndrisa Sep 25, 2024 • edited Loading

Choose a reason for hiding this comment

rgetz Oct 22, 2024

Choose a reason for hiding this comment

AAndrisa commented Sep 25, 2024 • edited Loading

tfcollins commented Oct 2, 2024

tfcollins left a comment

Choose a reason for hiding this comment

stephenkilbaneadi Oct 8, 2024

Choose a reason for hiding this comment

AAndrisa commented Oct 15, 2024

rgetz left a comment • edited Loading

Choose a reason for hiding this comment

AAndrisa commented Oct 22, 2024

AAndrisa commented Oct 22, 2024

rgetz left a comment •

edited

Loading

AAndrisa Sep 25, 2024 •

edited

Loading

AAndrisa commented Sep 25, 2024 •

edited

Loading

rgetz left a comment •

edited

Loading