Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure players refreshed after group event #106

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

andrewsayre
Copy link
Owner

Description:

This ensures that player base attributes are updated on a groups changed event even when groups are not loaded. This ensures that HeosPlayer.group_id is updated and does not become stale. Optimizes the player update so it does not do a full deep refresh, and instead only does the top level.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added/updated. No exclusions in .coveragerc permitted.
  • README.MD updated (if necessary)

@andrewsayre andrewsayre merged commit 24755ff into dev Feb 24, 2025
5 checks passed
@andrewsayre andrewsayre deleted the fix_update_refresh branch February 24, 2025 16:41
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (88c1b25) to head (6b5949e).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #106   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines         2014      2023    +9     
=========================================
+ Hits          2014      2023    +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant