Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deadlock when calling command within command_error handler #59

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

andrewsayre
Copy link
Owner

Description:

Moves the invocation of the command_error callbacks outside of the held lock for commands so that other commands could be called within the callback.

Related issue (if applicable): fixes #58

Checklist:

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added/updated. No exclusions in .coveragerc permitted.
  • README.MD updated (if necessary)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.68%. Comparing base (ea86b51) to head (6690861).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #59   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files          17       17           
  Lines        1604     1607    +3     
=======================================
+ Hits         1599     1602    +3     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewsayre andrewsayre merged commit c13c6eb into dev Jan 7, 2025
5 checks passed
@andrewsayre andrewsayre deleted the fix_command_lock branch January 7, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling another command within the credential error callback deadlocks
2 participants