Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add incremental backoff #78

Merged
merged 1 commit into from
Jan 11, 2025
Merged

Add incremental backoff #78

merged 1 commit into from
Jan 11, 2025

Conversation

andrewsayre
Copy link
Owner

Description:

Adds incremental backoff logic to the reconnection task, with a ceiling of 10min. This also means that the maximum reconnect delay can be 10min.

Related issue (if applicable): fixes #77

Checklist:

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added/updated. No exclusions in .coveragerc permitted.
  • README.MD updated (if necessary)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 99.76%. Comparing base (1938cb0) to head (ee07f16).

Files with missing lines Patch % Lines
pyheos/connection.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #78   +/-   ##
=======================================
  Coverage   99.76%   99.76%           
=======================================
  Files          19       19           
  Lines        2118     2122    +4     
=======================================
+ Hits         2113     2117    +4     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewsayre andrewsayre merged commit dffd597 into dev Jan 11, 2025
5 checks passed
@andrewsayre andrewsayre deleted the incremental_backoff branch January 11, 2025 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add incremental backoff to reconnect logic
2 participants