Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine mixins with command creation #82

Merged
merged 4 commits into from
Jan 11, 2025
Merged

Combine mixins with command creation #82

merged 4 commits into from
Jan 11, 2025

Conversation

andrewsayre
Copy link
Owner

Description:

Combine mixins with command creation logic into one set of APIs.

Related issue (if applicable): closes #81

Checklist:

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added/updated. No exclusions in .coveragerc permitted.
  • README.MD updated (if necessary)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.74%. Comparing base (1d49cc0) to head (fedca4b).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #82      +/-   ##
==========================================
- Coverage   99.76%   99.74%   -0.02%     
==========================================
  Files          19       21       +2     
  Lines        2128     1971     -157     
==========================================
- Hits         2123     1966     -157     
  Misses          5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewsayre andrewsayre merged commit d01b1d1 into dev Jan 11, 2025
5 checks passed
@andrewsayre andrewsayre deleted the refactor_mixins branch January 11, 2025 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combine command.* classes with the equivalent mixins to reduce code
2 participants