Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh players after group event #89

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Conversation

andrewsayre
Copy link
Owner

Description:

Ensures that players are refreshed after groups change so that group_id and any other attributes are updated (only if players have been loaded.)

Related issue (if applicable): fixes #86

Checklist:

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added/updated. No exclusions in .coveragerc permitted.
  • README.MD updated (if necessary)

@andrewsayre andrewsayre merged commit 8a652dc into dev Jan 23, 2025
5 checks passed
@andrewsayre andrewsayre deleted the refresh_players_after_group branch January 23, 2025 23:21
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.74%. Comparing base (4793483) to head (a35984d).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #89   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files          21       21           
  Lines        1969     1971    +2     
=======================================
+ Hits         1964     1966    +2     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewsayre andrewsayre mentioned this pull request Jan 26, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Player group_id and now_playing_media do not update after group change event
2 participants