Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify heart beat loop logic #92

Merged
merged 2 commits into from
Jan 26, 2025
Merged

Simplify heart beat loop logic #92

merged 2 commits into from
Jan 26, 2025

Conversation

andrewsayre
Copy link
Owner

Description:

Simplifies the try/except logic in the heart beat handler.

Related issue (if applicable): fixes #

Checklist:

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added/updated. No exclusions in .coveragerc permitted.
  • README.MD updated (if necessary)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.84%. Comparing base (8ccb03f) to head (c333b42).

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #92      +/-   ##
==========================================
+ Coverage   99.74%   99.84%   +0.10%     
==========================================
  Files          22       22              
  Lines        1976     1975       -1     
==========================================
+ Hits         1971     1972       +1     
+ Misses          5        3       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewsayre andrewsayre merged commit 35a6e5e into dev Jan 26, 2025
5 checks passed
@andrewsayre andrewsayre deleted the tweak_heartbeat branch January 26, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants