Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use enum for HeosNowPlayingMedia.type #95

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Conversation

andrewsayre
Copy link
Owner

Description:

Updates the HeosNowPlayingMedia class so that type is of type MediaType instead of a string.

Related issue (if applicable): fixes #

Checklist:

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added/updated. No exclusions in .coveragerc permitted.
  • README.MD updated (if necessary)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.84%. Comparing base (e4cd44d) to head (a5184c7).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev      #95   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files          22       22           
  Lines        1973     1978    +5     
=======================================
+ Hits         1970     1975    +5     
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewsayre andrewsayre merged commit dece8a6 into dev Jan 26, 2025
5 checks passed
@andrewsayre andrewsayre deleted the now_playing_media_type branch January 26, 2025 04:19
@andrewsayre andrewsayre mentioned this pull request Jan 26, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants