Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to Connection #96

Merged
merged 1 commit into from
Jan 26, 2025
Merged

Conversation

andrewsayre
Copy link
Owner

Description:

Makes some minor improvements to the connection logic:

  • Names tasks
  • Uses suppress instead of try/except/pass
  • Removes unnecessary catching of derived exceptions (e.g. ConnectionError is derived from OSError which we were also catching)
  • Modified test to wait out reconnect task
  • Test coverage is now 100%

Related issue (if applicable): fixes #

Checklist:

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • [X ] Tests have been added/updated. No exclusions in .coveragerc permitted.
  • README.MD updated (if necessary)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e4cd44d) to head (d7bc9bd).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff             @@
##              dev       #96      +/-   ##
===========================================
+ Coverage   99.84%   100.00%   +0.15%     
===========================================
  Files          22        22              
  Lines        1973      1974       +1     
===========================================
+ Hits         1970      1974       +4     
+ Misses          3         0       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andrewsayre andrewsayre merged commit 2c58e0e into dev Jan 26, 2025
5 checks passed
@andrewsayre andrewsayre deleted the connection_improvements branch January 26, 2025 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants