Skip to content

Conversation

@riggaroo
Copy link
Collaborator

@riggaroo riggaroo commented Dec 8, 2025

Update Compose + other dependencies to 1.10 too.

…f Gradle plugin.

Update Compose + other dependencies to 1.10 etc
@riggaroo riggaroo requested a review from tiwiz as a code owner December 8, 2025 11:59
@riggaroo riggaroo requested review from JoseAlcerreca and removed request for tiwiz December 8, 2025 11:59
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @riggaroo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant dependency upgrade, bringing the project up to date with newer versions of the Android Gradle Plugin and several core Compose libraries. A key part of this update involves the temporary removal of the composeScreenshot testing plugin, as it currently lacks compatibility with the updated Gradle environment. Additionally, minor code refactorings were applied to streamline shared element transition configurations.

Highlights

  • Dependency Updates: Updated several key dependencies, including the Android Gradle Plugin (AGP) to 8.13.1, various Compose-related libraries (activityCompose, adaptive, animationAndroid), CameraX, and Kotlin Symbol Processing (KSP).
  • Screenshot Testing Plugin Removal: The composeScreenshot testing plugin and its associated configurations have been temporarily removed or disabled across multiple feature modules and globally in gradle.properties due to compatibility issues with newer Gradle versions.
  • Code Refactoring: Simplified the implementation of BoundsTransform for shared element transitions in Motion.kt and SharedElementsConfig.kt by using lambda expressions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several dependencies, including the Android Gradle Plugin, Compose, and CameraX, and also removes the screenshot testing plugin due to compatibility issues with newer Gradle versions. The Kotlin code refactoring in Motion.kt and SharedElementsConfig.kt to use SAM conversions is a good improvement for code conciseness.

My review focuses on the dependency updates in gradle/libs.versions.toml. I've identified a critical version mismatch with KSP that will likely break the build, and an inconsistency in how Compose dependencies are versioned which could lead to runtime issues. Please see the detailed comments.

@riggaroo riggaroo merged commit c82d8e0 into main Dec 8, 2025
4 checks passed
@riggaroo riggaroo deleted the riggaroo/remove-screenshot-testing branch December 8, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants