Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AAP-30754 - Add analytics collector to EDA #1048

Closed
wants to merge 3 commits into from

Conversation

hsong-rh
Copy link
Contributor

@hsong-rh hsong-rh commented Sep 10, 2024

@hsong-rh hsong-rh requested a review from a team as a code owner September 10, 2024 20:49
@hsong-rh hsong-rh marked this pull request as draft September 10, 2024 20:50
Copy link
Collaborator

@Alex-Izquierdo Alex-Izquierdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hsong-rh What if we used the ORM to generate all the queries? This approach would improve maintainability and help prevent potential issues when changes are made to the model later on. Just make sure that the datetime values are properly formatted.

@Alex-Izquierdo
Copy link
Collaborator

Even I would suggest to explore https://palewi.re/docs/django-postgres-copy/ which adds COPY support for django.

@hsong-rh hsong-rh force-pushed the analytics branch 9 times, most recently from 714dc31 to 321a0b1 Compare September 16, 2024 13:57
@hsong-rh
Copy link
Contributor Author

Even I would suggest to explore https://palewi.re/docs/django-postgres-copy/ which adds COPY support for django.

Good suggestions, will work on it in the future.

@hsong-rh hsong-rh force-pushed the analytics branch 2 times, most recently from 36255e1 to 2cd7ae5 Compare September 16, 2024 14:24
@hsong-rh hsong-rh marked this pull request as ready for review September 16, 2024 14:24
@hsong-rh hsong-rh force-pushed the analytics branch 4 times, most recently from 6f53b3f to d17bbc4 Compare September 17, 2024 22:01
@hsong-rh hsong-rh force-pushed the analytics branch 4 times, most recently from 31330b0 to 79e132b Compare September 18, 2024 20:28
Alex-Izquierdo and others added 3 commits September 19, 2024 15:55
Signed-off-by: Alex <aizquier@redhat.com>
Co-authored-by: Bill Wei <bilwei@redhat.com>
Co-authored-by: Joe Shimkus <35382397+jshimkus-rh@users.noreply.github.com>
Co-authored-by: Elijah DeLee <kdelee@redhat.com>
Copy link

@hsong-rh
Copy link
Contributor Author

moved to #1065

@hsong-rh hsong-rh closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants