feat: AAP-30754 - Add analytics collector to EDA #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzwei
reviewed
Sep 20, 2024
bzwei
requested changes
Sep 20, 2024
hsong-rh
force-pushed
the
aap-30754
branch
2 times, most recently
from
78f7ab9 to
dca038d
Compare
bzwei
reviewed
Sep 23, 2024
hsong-rh
force-pushed
the
aap-30754
branch
2 times, most recently
from
6e1f458 to
3d00ff8
Compare
bzwei
previously approved these changes
Sep 24, 2024
hsong-rh
force-pushed
the
aap-30754
branch
2 times, most recently
from
6a399d8 to
7cea9a4
Compare
Except for the options parser part, the core collector logic has already been tested in test_analytics_collectors.py. But I will add a test for the command. |
hsong-rh
force-pushed
the
aap-30754
branch
2 times, most recently
from
3b20358 to
5a2a641
Compare
|
@Alex-Izquierdo The test has been added. |
bzwei
approved these changes
Sep 26, 2024
Alex-Izquierdo
approved these changes
Sep 27, 2024
AlanCoding
pushed a commit
to AlanCoding/eda-server
that referenced
this pull request
Oct 1, 2024
bzwei
added a commit
to bzwei/eda-server
that referenced
this pull request
Oct 18, 2024
…)" This reverts commit fb04499. Revert "fix: add IsSystemAdmin permission check (ansible#1078)" This reverts commit fcd649c. Revert "feat: AAP-30754 - Add analytics collector to EDA (ansible#1065)" This reverts commit d7e8389. Revert "feat: add settings/system/ API endpoint (ansible#1064)" This reverts commit e1912cf. Revert "Merge devel into main (ansible#1063)" This reverts commit ba13524.
bzwei
pushed a commit
to bzwei/eda-server
that referenced
this pull request
Oct 21, 2024
jshimkus-rh
pushed a commit
to jshimkus-rh/eda-server
that referenced
this pull request
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/AAP-30754
replace #1048
depends: #1049