-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CELEBORN-1054] Support db based dynamic config service #2273
Conversation
44bbbe4
to
dd5ee76
Compare
My suggestion may be a bit paranoid: can we avoid using the ORM framework and involve additional configuration files other than With a thin wrapper, we can write the vanilla JDBC API like
|
After offline discussion, we currently tend to keep using the orm (ibatis) framework, and at the same time unify Database-related configurations to CelebornConf. |
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
Outdated
Show resolved
Hide resolved
service/src/main/java/org/apache/celeborn/server/common/service/config/ConfigService.java
Show resolved
Hide resolved
service/src/main/java/org/apache/celeborn/server/common/service/config/DbConfigServiceImpl.java
Show resolved
Hide resolved
service/src/main/java/org/apache/celeborn/server/common/service/store/IServiceManager.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/celeborn/server/common/service/store/db/DbServiceManagerImpl.java
Outdated
Show resolved
Hide resolved
service/src/main/java/org/apache/celeborn/server/common/service/utils/JSON.java
Outdated
Show resolved
Hide resolved
...ce/src/main/java/org/apache/celeborn/server/common/service/config/BaseConfigServiceImpl.java
Outdated
Show resolved
Hide resolved
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
Outdated
Show resolved
Hide resolved
9ee2121
to
04d152d
Compare
...e/src/main/java/org/apache/celeborn/server/common/service/store/db/DbServiceManagerImpl.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/celeborn/server/common/service/store/db/DbServiceManagerImpl.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/celeborn/server/common/service/store/db/DbServiceManagerImpl.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/apache/celeborn/server/common/service/store/db/DbServiceManagerImpl.java
Outdated
Show resolved
Hide resolved
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
Outdated
Show resolved
Hide resolved
service/src/main/java/org/apache/celeborn/server/common/service/config/DbConfigServiceImpl.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/celeborn/server/common/service/store/db/mapper/ClusterInfoMapper.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/celeborn/server/common/service/store/db/mapper/ClusterInfoMapper.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor issues, almost good
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
Outdated
Show resolved
Hide resolved
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
Outdated
Show resolved
Hide resolved
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks all, merge to main(v0.5.0) |
### What changes were proposed in this pull request? Support database based store backend implementation for dynamic configuration management ### Why are the changes needed? Currently celeborn provides `FsConfigServiceImpl` implementation for dynamic config service which is based on file system, We cloud Support database based store backend implementation. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - `ConfigServiceSuiteJ#testDbConfig` Closes apache#2273 from RexXiong/CELEBORN-1054. Authored-by: Shuang <lvshuang.xjs@alibaba-inc.com> Signed-off-by: Shuang <lvshuang.xjs@alibaba-inc.com>
What changes were proposed in this pull request?
Support database based store backend implementation for dynamic configuration management
Why are the changes needed?
Currently celeborn provides
FsConfigServiceImpl
implementation for dynamic config service which is based on file system, We cloud Support database based store backend implementation.Does this PR introduce any user-facing change?
No
How was this patch tested?
ConfigServiceSuiteJ#testDbConfig