Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MJLINK-85] Fix issue with single quoting every argument #212

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

matriv
Copy link

@matriv matriv commented Jul 31, 2024

Each argument is first double quoted, but because of the default configuration of org.apache.maven.shared.utils.cli.shell.Shell is also single quoted on top. This leads to a shell command line which is not executable.

To fix this, leave the double quoting of each argument as it was, disable the single quoting of each argument with Shell configuration and wrap all the arguments as a whole string with single quotes, so that they are passed into bin/sh -c, example:

bin/sh -c '"--module-path" "foo:bar" "--add-modules" "mod1,mod2"'

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Make sure there is a JIRA issue filed
    for the change (usually before you start working on it). Trivial changes like typos do not
    require a JIRA issue. Your pull request should address just this issue, without
    pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [MJLINK-XXX] - Fixes bug in ApproximateQuantiles,
    where you replace MJLINK-XXX with the appropriate JIRA issue. Best practice
    is to use the JIRA issue title in the pull request title and in the first line of the
    commit message.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean verify to make sure basic checks pass. A more thorough check will
    be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its clean verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@matriv matriv marked this pull request as draft July 31, 2024 11:22
Each argument is first double quoted, but because of the default
configuration of `org.apache.maven.shared.utils.cli.shell.Shell`
is also single quoted on top. This leads to a shell command line
which is not executable.

To fix this, leave the double quoting of each argument as it was,
disable the single quoting of each argument with `Shell` configuration
and wrap all the arguments as a whole string with single quotes, so
that they are passed into `bin/sh -c`, example:

```
bin/sh -c '"--module-path" "foo:bar" "--add-modules" "mod1,mod2"'
```
@matriv matriv marked this pull request as ready for review July 31, 2024 17:34
@jdvlio
Copy link

jdvlio commented Nov 5, 2024

In the interim, since this was posted, I confirmed that this is still an issue. I needed to specify multiple JVM options in my build configuration and can also confirm that this patch resolves this issue.

EDIT: Apologies, thought I was at #196 when I posted this. I have yet to try out the PR in the current thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants